luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-08-30 01:38:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

Support SVA goto repetition with range [->M:N] (#7569)

Browse Source
This commit is contained in:
Yilou Wang
2026-05-11 07:07:51 -04:00
committed by GitHub
parent 485c0e746c
commit b0d58bbcef
17 changed files with 397 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Width.cpp
+36
View File
@@ -1745,6 +1745,7 @@ class WidthVisitor final : public VNVisitor {
if (m_vup->prelim()) {
iterateCheckBool(nodep, "exprp", nodep->exprp(), BOTH);
userIterateAndNext(nodep->countp(), WidthVP{SELF, BOTH}.p());
if (nodep->maxCountp()) widthCheckGotoRepRange(nodep, "Goto");
nodep->dtypeSetBit();
}
}
@@ -1753,9 +1754,44 @@ class WidthVisitor final : public VNVisitor {
if (m_vup->prelim()) {
iterateCheckBool(nodep, "exprp", nodep->exprp(), BOTH);
userIterateAndNext(nodep->countp(), WidthVP{SELF, BOTH}.p());
if (nodep->maxCountp()) widthCheckGotoRepRange(nodep, "Nonconsecutive");
nodep->dtypeSetBit();
}
}
// IEEE 1800-2023 16.9.2 range-form bound validation for goto/nonconsec.
// Parent accessors are re-fetched after constifyParamsEdit because that
// call can replace the node in-tree (Lesson: AstSConsRep visitor pattern).
// Templated to cover AstSGotoRep and AstSNonConsRep uniformly.
template <typename T_Rep>
void widthCheckGotoRepRange(T_Rep* nodep, const char* kind) {
userIterateAndNext(nodep->maxCountp(), WidthVP{SELF, BOTH}.p());
V3Const::constifyParamsEdit(nodep->countp());
V3Const::constifyParamsEdit(nodep->maxCountp());
const AstConst* const minConstp = VN_CAST(nodep->countp(), Const);
const AstConst* const maxConstp = VN_CAST(nodep->maxCountp(), Const);
if (!minConstp || !maxConstp) {
nodep->v3error(std::string{kind}
+ " repetition range bounds must be constant expressions"
" (IEEE 1800-2023 16.9.2)");
return;
}
if (minConstp->toSInt() < 0) {
nodep->v3error(std::string{kind}
+ " repetition range min count must be non-negative"
" (IEEE 1800-2023 16.9.2)");
return;
}
if (maxConstp->toSInt() < minConstp->toSInt()) {
nodep->v3error(std::string{kind}
+ " repetition range max count must be >= min count"
" (IEEE 1800-2023 16.9.2)");
return;
}
if (minConstp->isZero()) {
nodep->v3warn(E_UNSUPPORTED, std::string{"Unsupported: zero min count in "} + kind
+ " repetition range (IEEE 1800-2023 16.9.2)");
}
}
void visit(AstSThroughout* nodep) override {
m_hasSExpr = true;
assertAtExpr(nodep);