luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-09-01 18:36:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add warning on global constraints (#5625)

Browse Source
This commit is contained in:
Ryszard Rozak
2024-11-22 08:47:14 -05:00
committed by GitHub
parent 58dae8f931
commit ae990ebcda
4 changed files with 85 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Randomize.cpp
+20 -16
View File
@@ -438,26 +438,16 @@ class RandomizeMarkVisitor final : public VNVisitor {
if (nodep->varp()->lifetime().isStatic()) m_staticRefs.emplace(nodep);
if (!nodep->varp()->rand().isRandomizable()) return;
for (AstNode* backp = nodep; backp != m_constraintExprGenp && !backp->user1();
backp = backp->backp())
backp->user1(true);
if (nodep->varp()->rand().isRandomizable()) nodep->user1(true);
}
void visit(AstMemberSel* nodep) override {
if (!m_constraintExprGenp) return;
if (VN_IS(nodep->fromp(), LambdaArgRef)) {
if (!nodep->varp()->rand().isRandomizable()) return;
for (AstNode* backp = nodep; backp != m_constraintExprGenp && !backp->user1();
backp = backp->backp())
backp->user1(true);
}
}
void visit(AstArraySel* nodep) override {
if (!m_constraintExprGenp) return;
for (AstNode* backp = nodep; backp != m_constraintExprGenp && !backp->user1();
backp = backp->backp())
backp->user1(true);
iterateChildrenConst(nodep);
// Member select are randomized when both object and member are marked as rand.
// Variable references in with clause are converted to member selects and their from() is
// of type AstLambdaArgRef. They are randomized too.
const bool randObject = nodep->fromp()->user1() || VN_IS(nodep->fromp(), LambdaArgRef);
nodep->user1(randObject && nodep->varp()->rand().isRandomizable());
}
void visit(AstNodeModule* nodep) override {
VL_RESTORER(m_modp);
@@ -473,6 +463,14 @@ class RandomizeMarkVisitor final : public VNVisitor {
iterateChildrenConst(nodep);
}
void visit(AstNodeExpr* nodep) override {
iterateChildrenConst(nodep);
if (!m_constraintExprGenp) return;
nodep->user1((nodep->op1p() && nodep->op1p()->user1())
|| (nodep->op2p() && nodep->op2p()->user1())
|| (nodep->op3p() && nodep->op3p()->user1())
|| (nodep->op4p() && nodep->op4p()->user1()));
}
void visit(AstNode* nodep) override { iterateChildrenConst(nodep); }
public:
@@ -735,6 +733,12 @@ class ConstraintExprVisitor final : public VNVisitor {
handle.relink(indexp);
editSMT(nodep, nodep->fromp(), indexp);
}
void visit(AstMemberSel* nodep) override {
if (nodep->user1()) {
nodep->v3warn(CONSTRAINTIGN, "Global constraints ignored (unsupported)");
}
editFormat(nodep);
}
void visit(AstSFormatF* nodep) override {}
void visit(AstStmtExpr* nodep) override {}
void visit(AstConstraintIf* nodep) override {