luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-08-30 01:38:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix function-in-constraint internal error on bare port VarRef return (#7473) (#7480)

Browse Source 
Fixes #7473.
This commit is contained in:
Yilou Wang
2026-04-23 10:47:39 -04:00
committed by GitHub
parent 3149f43372
commit ae642facf5
3 changed files with 122 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Randomize.cpp
+13 -2
View File
@@ -2560,12 +2560,23 @@ class ConstraintExprVisitor final : public VNVisitor {
const V3TaskConnects tconnects
= V3Task::taskConnects(nodep, funcp->stmtsp(), nullptr, false);
// Clone return expression, substitute params with args
AstNodeExpr* const inlinedp = retExprp->cloneTreePure(false);
// Clone return expression, substitute params with args.
// Track the root via a local pointer: when the root itself is a VarRef to a port
// (e.g. body `F = d;`), the cloned root has no back pointer, so foreach's
// replaceWith would trip the "no back" assertion -- substitute the root pointer
// directly instead.
AstNodeExpr* inlinedp = retExprp->cloneTreePure(false);
for (const auto& tconnect : tconnects) {
const AstVar* const portp = tconnect.first;
AstArg* const argp = tconnect.second;
if (!argp || !argp->exprp()) continue;
if (AstVarRef* const rootRefp = VN_CAST(inlinedp, VarRef)) {
if (rootRefp->varp() == portp) {
inlinedp = argp->exprp()->cloneTreePure(false);
VL_DO_DANGLING(rootRefp->deleteTree(), rootRefp);
continue;
}
}
inlinedp->foreach([&](AstVarRef* refp) {
if (refp->varp() == portp) {
refp->replaceWith(argp->exprp()->cloneTreePure(false));