[#72179] add more notes

This commit is contained in:
Mateusz Gancarz 2025-02-10 15:52:02 +01:00
parent e49c06cb97
commit 9878587753
2 changed files with 8 additions and 2 deletions

View File

@ -259,7 +259,7 @@ void VerilatedSaif::close() VL_MT_SAFE_EXCLUDES(m_mutex) {
printStr("))\n"); printStr("))\n");
// NOTE: TZ, TX and TB will be allways 0 // NOTE: TZ, TX and TB will be allways 0
// NOTE: I.3.4 and I.3.5 mentions also about TZ, TB, TG, IG and IK // NOTE: I.3.4 and I.3.5 mentions also about TG, IG and IK
} }
activity.lastTime = m_time; activity.lastTime = m_time;
} }
@ -392,21 +392,27 @@ void VerilatedSaif::declare(uint32_t code, const char* name, const char* wirep,
const bool enabled = Super::declCode(code, hierarchicalName, bits); const bool enabled = Super::declCode(code, hierarchicalName, bits);
//NOTE: m_suffixes currently not used anywhere
if (m_suffixes.size() <= nextCode() * VL_TRACE_SUFFIX_ENTRY_SIZE) { if (m_suffixes.size() <= nextCode() * VL_TRACE_SUFFIX_ENTRY_SIZE) {
m_suffixes.resize(nextCode() * VL_TRACE_SUFFIX_ENTRY_SIZE * 2, 0); m_suffixes.resize(nextCode() * VL_TRACE_SUFFIX_ENTRY_SIZE * 2, 0);
} }
//NOTE: m_maxSignalBytes currently used only here
// Keep upper bound on bytes a single signal can emit into the buffer // Keep upper bound on bytes a single signal can emit into the buffer
m_maxSignalBytes = std::max<size_t>(m_maxSignalBytes, bits + 32); m_maxSignalBytes = std::max<size_t>(m_maxSignalBytes, bits + 32);
// Make sure write buffer is large enough, plus header // Make sure write buffer is large enough, plus header
bufferResize(m_maxSignalBytes + 1024); bufferResize(m_maxSignalBytes + 1024);
//NOTE: enabled is set much earlier but returned here
if (!enabled) return; if (!enabled) return;
const size_t block_size = 1024; const size_t block_size = 1024;
if (m_activityArena.empty() if (m_activityArena.empty()
|| m_activityArena.back().size() + bits > m_activityArena.back().capacity()) { || m_activityArena.back().size() + bits > m_activityArena.back().capacity()) {
m_activityArena.emplace_back(); m_activityArena.emplace_back();
fprintf(stdout, "Adding new activity arena block with size %d\n", block_size);
m_activityArena.back().reserve(block_size); m_activityArena.back().reserve(block_size);
} }
size_t bitsIdx = m_activityArena.back().size(); size_t bitsIdx = m_activityArena.back().size();

View File

@ -212,7 +212,7 @@ class VerilatedSaifBuffer VL_NOT_FINAL {
char* const m_wrFlushp = m_owner.parallel() ? nullptr : m_owner.m_wrFlushp; char* const m_wrFlushp = m_owner.parallel() ? nullptr : m_owner.m_wrFlushp;
// SAIF line end string codes + metadata // SAIF line end string codes + metadata
const char* const m_suffixes = m_owner.m_suffixes.data(); const char* const m_suffixes = m_owner.m_suffixes.data(); //NOTE: currently not used anywhere
// The maximum number of bytes a single signal can emit // The maximum number of bytes a single signal can emit
const size_t m_maxSignalBytes = m_owner.m_maxSignalBytes; const size_t m_maxSignalBytes = m_owner.m_maxSignalBytes;