luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-10-06 01:54:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove multi-threaded FST tracing (#7443)

Browse Source 
Remove parallel (using the FST library writer thread) and offloaded
(separate Verilator internal thread) tracing (only used by FST). These
are not compatible with #6992, and #5806 should yield better performance
in all cases.

Consequently mark '--trace-threads' and '--trace-fst-thread' options as
deprecated
This commit is contained in:
Geza Lore
2026-04-19 16:02:12 +01:00
committed by GitHub
parent f7a349c5a7
commit 97454a1bc5
40 changed files with 42 additions and 858 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Trace.cpp
+6 -17
View File
@@ -666,8 +666,7 @@ class TraceVisitor final : public VNVisitor {
// Add it to top scope
m_topScopep->addBlocksp(funcp);
const std::string bufArg
= v3Global.opt.traceClassBase()
+ "::" + (v3Global.opt.useTraceOffload() ? "OffloadBuffer" : "Buffer") + "* bufp"
= v3Global.opt.traceClassBase() + "::Buffer* bufp"
+ (declp ? (", uint32_t offset, const " + declp->dtypep()->cType("", true, true)
+ " __VdtypeVar")
: "");
@@ -710,21 +709,11 @@ class TraceVisitor final : public VNVisitor {
+ (declp ? " + offset" : "") + ");\n"});
} else {
// Change dump sub function
if (v3Global.opt.useTraceOffload()) {
funcp->addStmtsp(new AstCStmt{flp, //
"const uint32_t base VL_ATTR_UNUSED = "
"vlSymsp->__Vm_baseCode + "
+ (declp ? " offset" : cvtToStr(baseCode))
+ ";\n"});
funcp->addStmtsp(
new AstCStmt{flp, "(void)bufp; // Prevent unused variable warning\n"});
} else {
funcp->addStmtsp(new AstCStmt{flp, //
"uint32_t* const oldp VL_ATTR_UNUSED = "
"bufp->oldp(vlSymsp->__Vm_baseCode + "
+ (declp ? " offset" : cvtToStr(baseCode))
+ ");\n"});
}
funcp->addStmtsp(new AstCStmt{flp, //
"uint32_t* const oldp VL_ATTR_UNUSED = "
"bufp->oldp(vlSymsp->__Vm_baseCode + "
+ (declp ? " offset" : cvtToStr(baseCode))
+ ");\n"});
}
if (!declp) {
// Add call to top function