luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-10-06 01:54:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix reading another parameter resolves to 0 in cloned modules (#8086) (#8069)

Browse Source
This commit is contained in:
em2machine
2026-08-15 06:06:25 -04:00
committed by GitHub
parent 3334576b1d
commit 93401038c0
3 changed files with 64 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Param.cpp
+11 -1
View File
@@ -1442,9 +1442,19 @@ class ParamProcessor final {
// Cast/CastSize default values are not yet folded by V3Width.
// Constify here so the comparison below sees a Const node.
// Other node kinds are handled in the branches above.
//
// Only fold when the cast is self-contained. modvarp is the
// parameter on the shared module template and constifyParamsEdit
// is destructive: a default that reads another parameter
// (VarRef) or a type parameter (RefDType) must be evaluated per
// instance, and folding it here would evaluate it against the
// template's own defaults and bake that in for every later
// instance that relies on the default.
if (modvarp->valuep()
&& (VN_IS(modvarp->valuep(), Cast) || VN_IS(modvarp->valuep(), CastSize))) {
V3Const::constifyParamsEdit(modvarp->valuep());
const bool dependent = modvarp->valuep()->exists(
[](AstNode* np) { return VN_IS(np, VarRef) || VN_IS(np, RefDType); });
if (!dependent) V3Const::constifyParamsEdit(modvarp->valuep());
}
UINFO(9, "cellPinCleanup: after constify " << pinp);
// String constants are parsed as logic arrays and converted to strings in V3Const.