luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-09-05 16:45:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix regression rejecting boolean !x inside sequence expressions (#7549) (#7551)

Browse Source 
Fixes #7549.
This commit is contained in:
Yilou Wang
2026-05-08 18:34:28 -04:00
committed by GitHub
parent 5820d2936c
commit 8eca6b8fe7
6 changed files with 120 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Width.cpp
+5 -2
View File
@@ -7658,7 +7658,7 @@ class WidthVisitor final : public VNVisitor {
}
}
void visit_log_not(AstNode* nodep) {
void visit_log_not(AstLogNot* nodep) {
// CALLER: LogNot
// Width-check: lhs 1 bit
// Real: Allowed; implicitly compares with zero
@@ -7674,7 +7674,10 @@ class WidthVisitor final : public VNVisitor {
if (m_vup->prelim()) {
iterateCheckBool(nodep, "LHS", nodep->op1p(), BOTH);
nodep->dtypeSetBit();
if (m_underSExpr) {
// IEEE 1800-2023 16.12.3: property 'not' is not a sequence operator.
// Boolean '!' is allowed in sequences (16.7 expression_or_dist).
// The parser distinguishes the two via AstLogNot::fromProperty().
if (m_underSExpr && nodep->fromProperty()) {
nodep->v3error("Unexpected 'not' in sequence expression context");
AstConst* const newp = new AstConst{nodep->fileline(), 0};
newp->dtypeFrom(nodep);