luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-08-22 14:06:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix Replicate with unsigned count but MSB set (#6231) (#6233)

Browse Source 
Correctly compute witdh of AstReplicate in its constructor when the
count is unsigned but its MSB is set.
This commit is contained in:
Geza Lore
2025-07-27 12:30:19 +02:00
committed by GitHub
parent 1725ee9c52
commit 895b85a16e
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3AstNodeExpr.h
+3 -2
View File
@@ -3367,8 +3367,9 @@ public:
: ASTGEN_SUPER_Replicate(fl, lhsp, rhsp) { : ASTGEN_SUPER_Replicate(fl, lhsp, rhsp) {
if (lhsp) { if (lhsp) {
if (const AstConst* const constp = VN_CAST(rhsp, Const)) { if (const AstConst* const constp = VN_CAST(rhsp, Const)) {
if (constp->num().isFourState() || constp->num().isNegative()) { // V3Width warns if (constp->num().isFourState()
dtypeSetLogicSized(lhsp->width(), VSigning::UNSIGNED); || (constp->dtypep()->isSigned() && constp->num().isNegative())) {
dtypeSetLogicSized(lhsp->width(), VSigning::UNSIGNED); // V3Width warns
} else { } else {
dtypeSetLogicSized(lhsp->width() * constp->toSInt(), VSigning::UNSIGNED); dtypeSetLogicSized(lhsp->width() * constp->toSInt(), VSigning::UNSIGNED);
} }
test_regress/t/t_dfg_peephole.v
+4
View File
@@ -243,6 +243,10 @@ module t (
assign ascending_assign[4:7] = arand_b[0:3]; assign ascending_assign[4:7] = arand_b[0:3];
`signal(ASCENDING_ASSIGN, ascending_assign); `signal(ASCENDING_ASSIGN, ascending_assign);
// Special cases to be covered
`signal(REPLICATE_WIDTH, {4'd8{rand_a[0]}}); // Replicate count unsigned, but MSB set
if ($bits(REPLICATE_WIDTH) != 8) $fatal("%0d != 8", $bits(REPLICATE_WIDTH));
// Sel from not requires the operand to have a sinle sink, so can't use // Sel from not requires the operand to have a sinle sink, so can't use
// the chekc due to the raw expression referencing the operand // the chekc due to the raw expression referencing the operand
wire [63:0] sel_from_not_tmp = ~(rand_a >> rand_b[2:0] << rand_a[3:0]); wire [63:0] sel_from_not_tmp = ~(rand_a >> rand_b[2:0] << rand_a[3:0]);