luke
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Optimize associative constant patterns to fixed point (#8147) 

Re-associating constants can enable further simplification e.g. when
those constant become all zero/all ones. Run these patterns to fixed
point to capture the simplification, by revisiting the node.
This commit is contained in:
Geza Lore 2026-08-18 19:41:24 +02:00 committed by GitHub
parent 8a29360ade
commit 86b7cfb05c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/V3Const.cpp
View File

@ -1709,8 +1709,7 @@ class ConstVisitor final : public VNVisitor {
const V3Number num{constp, subsize, constp->num()}; const V3Number num{constp, subsize, constp->num()};
nodep->lhsp(new AstConst{constp->fileline(), num}); nodep->lhsp(new AstConst{constp->fileline(), num});
VL_DO_DANGLING(pushDeletep(constp), constp); VL_DO_DANGLING(pushDeletep(constp), constp);
UINFOTREE(9, nodep, "", "BI(EXTEND)-ou"); return false; // input node is still valid, keep going
return true;
} }
bool operandBiExtendConstOver(const AstNodeBiop* nodep) { bool operandBiExtendConstOver(const AstNodeBiop* nodep) {
// EQ(const{width32}, EXTEND(xx{width3})) -> constant // EQ(const{width32}, EXTEND(xx{width3})) -> constant
@ -2070,7 +2069,7 @@ class ConstVisitor final : public VNVisitor {
rp->rhsp(bp); rp->rhsp(bp);
rp->dtypeFrom(nodep); // Upper widthMin more likely correct rp->dtypeFrom(nodep); // Upper widthMin more likely correct
if (VN_IS(rp->lhsp(), Const) && VN_IS(rp->rhsp(), Const)) replaceConst(rp); if (VN_IS(rp->lhsp(), Const) && VN_IS(rp->rhsp(), Const)) replaceConst(rp);
// UINFOTREE(1, nodep, "", "repAsvConst_new"); iterate(nodep); // Proceed to fixed point
} }
void replaceAsvLUp(AstNodeBiop* nodep) { void replaceAsvLUp(AstNodeBiop* nodep) {
// BIASV(BIASV(CONSTll,lr),r) -> BIASV(CONSTll,BIASV(lr,r)) // BIASV(BIASV(CONSTll,lr),r) -> BIASV(CONSTll,BIASV(lr,r))
@ -2083,7 +2082,7 @@ class ConstVisitor final : public VNVisitor {
lp->lhsp(lrp); lp->lhsp(lrp);
lp->rhsp(rp); lp->rhsp(rp);
lp->dtypeFrom(nodep); // Upper widthMin more likely correct lp->dtypeFrom(nodep); // Upper widthMin more likely correct
// UINFOTREE(1, nodep, "", "repAsvLUp_new"); iterate(nodep); // Proceed to fixed point
} }
void replaceAsvRUp(AstNodeBiop* nodep) { void replaceAsvRUp(AstNodeBiop* nodep) {
// BIASV(l,BIASV(CONSTrl,rr)) -> BIASV(CONSTrl,BIASV(l,rr)) // BIASV(l,BIASV(CONSTrl,rr)) -> BIASV(CONSTrl,BIASV(l,rr))
@ -2096,7 +2095,7 @@ class ConstVisitor final : public VNVisitor {
rp->lhsp(lp); rp->lhsp(lp);
rp->rhsp(rrp); rp->rhsp(rrp);
rp->dtypeFrom(nodep); // Upper widthMin more likely correct rp->dtypeFrom(nodep); // Upper widthMin more likely correct
// UINFOTREE(1, nodep, "", "repAsvRUp_new"); iterate(nodep); // Proceed to fixed point
} }
void replaceAndOr(AstNodeBiop* nodep) { void replaceAndOr(AstNodeBiop* nodep) {
// OR (AND (CONSTll,lr), AND(CONSTrl==ll,rr)) -> AND (CONSTll, OR(lr,rr)) // OR (AND (CONSTll,lr), AND(CONSTrl==ll,rr)) -> AND (CONSTll, OR(lr,rr))