luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-10-06 18:13:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix V3Task Inout pin resizing error (#8212)

Browse Source
This commit is contained in:
Pawel Klopotek
2026-08-25 10:27:24 -04:00
committed by GitHub
parent 69f42ea480
commit 821478070d
3 changed files with 104 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Task.cpp
+24 -15
View File
@@ -514,22 +514,31 @@ class TaskVisitor final : public VNVisitor {
AstNodeExpr* postRhsp = new AstVarRef{newvscp->fileline(), newvscp, VAccess::READ};
if (AstResizeLValue* soutPinp = VN_CAST(outPinp, ResizeLValue)) {
outPinp = soutPinp->lhsp();
if (AstNodeUniop* aoutPinp = VN_CAST(outPinp, Extend)) {
outPinp = aoutPinp->lhsp();
} else if (AstNodeUniop* aoutPinp = VN_CAST(outPinp, ExtendS)) {
outPinp = aoutPinp->lhsp();
} else if (AstSel* aoutPinp = VN_CAST(outPinp, Sel)) {
outPinp = aoutPinp->fromp();
} else {
outPinp->v3fatalSrc("Inout pin resizing should have had extend or select");
}
if (outPinp->width() < portp->width()) {
postRhsp = new AstSel{pinp->fileline(), postRhsp, 0, pinp->width()};
} else { // pin width > port width
if (pinp->isSigned() && postRhsp->isSigned()) {
postRhsp = new AstExtendS{pinp->fileline(), postRhsp};
if (VN_IS(outPinp, RToIRoundS) || VN_IS(outPinp, RToIS)) {
outPinp = VN_AS(outPinp, NodeUniop)->lhsp();
if (postRhsp->isSigned()) {
postRhsp = new AstISToRD{pinp->fileline(), postRhsp};
} else {
postRhsp = new AstExtend{pinp->fileline(), postRhsp};
postRhsp = new AstIToRD{pinp->fileline(), postRhsp};
}
} else {
if (AstNodeUniop* aoutPinp = VN_CAST(outPinp, Extend)) {
outPinp = aoutPinp->lhsp();
} else if (AstNodeUniop* aoutPinp = VN_CAST(outPinp, ExtendS)) {
outPinp = aoutPinp->lhsp();
} else if (AstSel* aoutPinp = VN_CAST(outPinp, Sel)) {
outPinp = aoutPinp->fromp();
} else {
outPinp->v3fatalSrc("Inout pin resizing should have had extend or select");
}
if (outPinp->width() < portp->width()) {
postRhsp = new AstSel{pinp->fileline(), postRhsp, 0, pinp->width()};
} else { // pin width > port width
if (pinp->isSigned() && postRhsp->isSigned()) {
postRhsp = new AstExtendS{pinp->fileline(), postRhsp};
} else {
postRhsp = new AstExtend{pinp->fileline(), postRhsp};
}
}
}
postRhsp->dtypeFrom(outPinp);