luke
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix data race on V3TSP edge IDs between parallel sorts (#7194)

This commit is contained in:
Shashvat Prabhu 2026-06-10 16:00:24 +05:30
parent de0236be2f
commit 7b77505ccd
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/CONTRIBUTORS
View File

@ -325,3 +325,4 @@ Yogish Sekhar
24bit-xjkp 24bit-xjkp
Zubin Jain Zubin Jain
Muzaffer Kal Muzaffer Kal
Shashvat Prabhu

5
src/V3TSP.cpp
View File

@ -41,8 +41,6 @@ VL_DEFINE_DEBUG_FUNCTIONS;
// Support classes // Support classes
namespace V3TSP { namespace V3TSP {
static uint32_t s_edgeIdNext = 0;
static void selfTestStates(); static void selfTestStates();
static void selfTestString(); static void selfTestString();
} // namespace V3TSP } // namespace V3TSP
@ -77,6 +75,7 @@ public:
// MEMBERS // MEMBERS
std::unordered_map<T_Key, Vertex*> m_vertices; // T_Key to Vertex lookup map std::unordered_map<T_Key, Vertex*> m_vertices; // T_Key to Vertex lookup map
uint32_t m_edgeIdNext = 0; // Next edge ID; IDs need only be unique within this graph
// CONSTRUCTORS // CONSTRUCTORS
TspGraphTmpl() TspGraphTmpl()
@ -105,7 +104,7 @@ public:
// The only time we may create duplicate edges is when // The only time we may create duplicate edges is when
// combining the MST with the perfect-matched pairs, // combining the MST with the perfect-matched pairs,
// and in that case, we want to permit duplicate edges. // and in that case, we want to permit duplicate edges.
const uint32_t edgeId = ++V3TSP::s_edgeIdNext; const uint32_t edgeId = ++m_edgeIdNext;
// We want to be able to compare edges quickly for a total // We want to be able to compare edges quickly for a total
// ordering, so pre-compute a sorting key and store it in // ordering, so pre-compute a sorting key and store it in