luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-09-06 08:57:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add check for mis-assignment of dynamic/automatics per IEEE

Browse Source
This commit is contained in:
Wilson Snyder
2025-08-10 07:23:28 -04:00
parent a74a3bb689
commit 641dd756c0
15 changed files with 168 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3WidthCommit.cpp
+43
View File
@@ -42,6 +42,7 @@ class WidthCommitVisitor final : public VNVisitor {
// STATE
AstNodeModule* m_modp = nullptr;
std::string m_contNba; // In continuous- or non-blocking assignment
VMemberMap m_memberMap; // Member names cached for fast lookup
public:
@@ -124,6 +125,26 @@ private:
}
}
}
void varLifetimeCheck(AstNode* nodep, AstVar* varp) {
if (!m_contNba.empty()) {
std::string varType;
const AstNodeDType* const varDtp = varp->dtypep()->skipRefp();
if (varp->lifetime().isAutomatic() && !VN_IS(varDtp, IfaceRefDType)
&& !(varp->isFuncLocal() && varp->isIO()))
varType = "Automatic lifetime";
else if (varp->isClassMember() && !varp->lifetime().isStatic()
&& !VN_IS(varDtp, IfaceRefDType))
varType = "Class non-static";
else if (varDtp->isDynamicallySized())
varType = "Dynamically-sized";
if (!varType.empty()) {
UINFO(1, " Related var dtype: " << varDtp);
nodep->v3error(varType
<< " variable not allowed in " << m_contNba
<< " assignment (IEEE 1800-2023 6.21): " << varp->prettyNameQ());
}
}
}
// VISITORS
void visit(AstNodeModule* nodep) override {
@@ -278,6 +299,27 @@ private:
iterateChildren(nodep);
editDType(nodep);
classEncapCheck(nodep, nodep->varp(), VN_CAST(nodep->classOrPackagep(), Class));
if (nodep->access().isWriteOrRW()) varLifetimeCheck(nodep, nodep->varp());
}
void visit(AstAssignDly* nodep) override {
iterateAndNextNull(nodep->timingControlp());
iterateAndNextNull(nodep->rhsp());
{
VL_RESTORER(m_contNba);
m_contNba = "nonblocking";
iterateAndNextNull(nodep->lhsp());
}
editDType(nodep);
}
void visit(AstAssignW* nodep) override {
iterateAndNextNull(nodep->timingControlp());
iterateAndNextNull(nodep->rhsp());
{
VL_RESTORER(m_contNba);
m_contNba = "continuous";
iterateAndNextNull(nodep->lhsp());
}
editDType(nodep);
}
void visit(AstNodeFTaskRef* nodep) override {
iterateChildren(nodep);
@@ -290,6 +332,7 @@ private:
if (auto* const classrefp = VN_CAST(nodep->fromp()->dtypep(), ClassRefDType)) {
classEncapCheck(nodep, nodep->varp(), classrefp->classp());
} // else might be struct, etc
varLifetimeCheck(nodep, nodep->varp());
}
void visit(AstVar* nodep) override {
iterateChildren(nodep);