luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-10-06 18:13:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Internals: Favor std::swap. No functional change.

Browse Source
This commit is contained in:
Wilson Snyder
2026-03-29 20:33:06 -04:00
parent 5036af3d37
commit 600eb7ec86
7 changed files with 12 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3WidthSel.cpp
+7 -21
View File
@@ -448,21 +448,15 @@ class WidthSelVisitor final : public VNVisitor {
adtypep,
"Array extraction with width miscomputed " << adtypep->width() << "/"
<< fromRange.elements());
if (fromRange.ascending()) {
// Below code assumes descending bit range; just works out if we swap
const int x = msb;
msb = lsb;
lsb = x;
}
// Below code assumes descending bit range; just works out if we swap
if (fromRange.ascending()) std::swap(msb, lsb);
if (lsb > msb) {
nodep->v3warn(
SELRANGE,
"[" << msb << ":" << lsb
<< "] Slice range has ascending bit ordering, perhaps you wanted [" << lsb
<< ":" << msb << "]");
const int x = msb;
msb = lsb;
lsb = x;
std::swap(msb, lsb);
}
const int elwidth = adtypep->width() / fromRange.elements();
AstSel* const newp
@@ -477,21 +471,15 @@ class WidthSelVisitor final : public VNVisitor {
nodep->replaceWith(newp);
VL_DO_DANGLING(pushDeletep(nodep), nodep);
} else if (VN_IS(ddtypep, BasicDType)) {
if (fromRange.ascending()) {
// Below code assumes descending bit range; just works out if we swap
const int x = msb;
msb = lsb;
lsb = x;
}
// Below code assumes descending bit range; just works out if we swap
if (fromRange.ascending()) std::swap(msb, lsb);
if (lsb > msb) {
nodep->v3warn(
SELRANGE,
"[" << msb << ":" << lsb
<< "] Slice range has ascending bit ordering, perhaps you wanted [" << lsb
<< ":" << msb << "]");
const int x = msb;
msb = lsb;
lsb = x;
std::swap(msb, lsb);
}
AstSel* const newp = new AstSel{nodep->fileline(), fromp, newSubLsbOf(lsbp, fromRange),
msb + 1 - lsb};
@@ -508,9 +496,7 @@ class WidthSelVisitor final : public VNVisitor {
"[" << msb << ":" << lsb
<< "] Slice range has ascending bit ordering, perhaps you wanted [" << lsb
<< ":" << msb << "]");
const int x = msb;
msb = lsb;
lsb = x;
std::swap(msb, lsb);
}
AstSel* const newp = new AstSel{nodep->fileline(), fromp, newSubLsbOf(lsbp, fromRange),
msb + 1 - lsb};