luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-10-07 18:42:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix access types of refs and inouts (#8380)

Browse Source
This commit is contained in:
Igor Zaworski
2026-09-18 07:46:56 -04:00
committed by GitHub
parent 3fd16ed498
commit 5f38b797f3
13 changed files with 121 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Task.cpp
+5 -5
View File
@@ -1002,7 +1002,7 @@ class TaskVisitor final : public VNVisitor {
vscp->varp()->protect(false);
portp->protect(false);
// Add argument to call
const VAccess access = portp->isWritable() ? VAccess::WRITE : VAccess::READ;
const VAccess access = portp->direction().pinAccess();
callp->add(", ");
callp->add(new AstVarRef{portp->fileline(), vscp, access});
return vscp;
@@ -2212,7 +2212,7 @@ AstNodeFTask* V3Task::taskConnectWrapNew(AstNodeFTask* taskp, const string& newn
} else { // Defaulting arg
AstNodeExpr* const valuep = VN_AS(portp->valuep(), NodeExpr);
if ((portp->isRef() || portp->isConstRef()) && VN_IS(valuep, VarRef)) {
const VAccess refAccess = portp->isWritable() ? VAccess::WRITE : VAccess::READ;
const VAccess refAccess = portp->direction().pinAccess();
AstVarRef* const refp = VN_AS(valuep->cloneTree(false), VarRef);
refp->access(refAccess);
AstArg* const newArgp = new AstArg{portp->fileline(), portp->name(), refp};
@@ -2235,9 +2235,9 @@ AstNodeFTask* V3Task::taskConnectWrapNew(AstNodeFTask* taskp, const string& newn
}
}
oldNewVars.emplace(portp, newPortp);
const VAccess pinAccess = portp->isWritable() ? VAccess::WRITE : VAccess::READ;
AstArg* const newArgp = new AstArg{portp->fileline(), portp->name(),
new AstVarRef{portp->fileline(), newPortp, pinAccess}};
AstArg* const newArgp = new AstArg{
portp->fileline(), portp->name(),
new AstVarRef{portp->fileline(), newPortp, portp->direction().pinAccess()}};
newCallp->addArgsp(newArgp);
}
// Create wrapper call to original, passing arguments, adding setting of return value