luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-09-06 08:57:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix generic interface port forwarded to a nested instance (#7454) (#7457)

Browse Source 
Fixes #7454.
This commit is contained in:
Yilou Wang
2026-04-27 21:15:25 -04:00
committed by GitHub
parent c460f0e6a0
commit 5d1b4fe8a8
4 changed files with 126 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3Param.cpp
+38
View File
@@ -1360,6 +1360,40 @@ class ParamProcessor final {
return isEq.isNeqZero();
}
// Rewrite placeholder __VGIfaceParam pins emitted by
// LinkDotResolveVisitor::addImplicitParametersOfGenericIface for a nested
// generic-interface forwarding chain (#7454). Must run here (not in
// V3LinkDot's Param/Resolve visitor at LDS_PARAMED) because:
// * linkDotParamed runs AFTER V3Param, at which point cellDeparam has
// already consumed the pin via moduleFindOrClone (variant naming off
// pinp->exprp()'s IfaceRefDType) and genericInterfaceVarSetup (hard
// VN_AS cast to IfaceRefDType); and
// * the enclosing module's port only becomes a concrete IfaceRefDType
// after its own nodeDeparam has specialized it. That specialization
// happens in V3Param's top-down walk, so the window between "outer
// port resolved" and "inner cellDeparam starts" exists only here.
void resolveGenericIfaceForwardingPins(AstPin* paramsp) {
for (AstPin* pinp = paramsp; pinp; pinp = VN_AS(pinp->nextp(), Pin)) {
if (!pinp->exprp()) continue;
if (!VString::startsWith(pinp->name(), "__VGIfaceParam")) continue;
const AstNodeVarRef* const fwdRefp = VN_CAST(pinp->exprp(), NodeVarRef);
if (!fwdRefp) continue;
const AstIfaceRefDType* const resolvedp
= VN_CAST(fwdRefp->varp()->childDTypep()->skipRefp(), IfaceRefDType);
UASSERT_OBJ(resolvedp, pinp,
"Generic interface forwarding pin not specialized before use");
AstIfaceRefDType* const newIrefp = new AstIfaceRefDType{
resolvedp->fileline(), resolvedp->modportFileline(), resolvedp->cellName(),
resolvedp->ifaceName(), resolvedp->modportName()};
newIrefp->ifacep(resolvedp->ifacep());
if (resolvedp->paramsp()) {
newIrefp->addParamsp(resolvedp->paramsp()->cloneTree(true));
}
pinp->exprp()->unlinkFrBack()->deleteTree();
pinp->exprp(newIrefp);
}
}
void cellPinCleanup(AstNode* nodep, AstPin* pinp, AstPin* paramsp, AstNodeModule* srcModp,
string& longnamer, bool& any_overridesr) {
if (!pinp->exprp()) return; // No-connect
@@ -2114,6 +2148,10 @@ public:
}
pinp = nextp;
}
// Nested generic-iface forwarding (#7454): rewrite VarRef placeholders
// left by V3LinkDot to concrete IfaceRefDTypes now that the enclosing
// module has been specialized.
resolveGenericIfaceForwardingPins(cellp->paramsp());
}
// Create new module name with _'s between the constants
UINFOTREE(10, nodep, "", "cell");