luke
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

verilog.y: fix accidental DEL omissions for wait_order, expect, property case 

Three node deletions were accidentally dropped from the initial covergroup
commit as collateral damage:
- wait_order (no-stmt variant): restore DEL($3) for vrdList
- expect (no-stmt variant): restore DEL($3) for property_spec
- property_exprCaseIf yIF/yELSE: restore DEL($3) for condition expr

In all three cases $3 is an AstNode* that is not assigned to $$ and would
be leaked without the deletion.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Matthew Ballance 2026-02-28 20:58:54 +00:00
parent 4005cd33fb
commit 42debebb07
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/verilog.y
View File

@ -3729,7 +3729,7 @@ statement_item<nodeStmtp>: // IEEE: statement_item
| yWAIT_ORDER '(' vrdList ')' stmt yELSE stmt
{ $$ = nullptr; BBUNSUP($4, "Unsupported: wait_order"); DEL($3, $5, $7);}
| yWAIT_ORDER '(' vrdList ')' yELSE stmt
{ $$ = nullptr; BBUNSUP($4, "Unsupported: wait_order"); DEL($6); }
{ $$ = nullptr; BBUNSUP($4, "Unsupported: wait_order"); DEL($3, $6); }
//
// // IEEE: procedural_assertion_statement
| procedural_assertion_statement { $$ = $1; }
@ -3746,7 +3746,7 @@ statement_item<nodeStmtp>: // IEEE: statement_item
| yEXPECT '(' property_spec ')' stmt yELSE stmt
{ $$ = nullptr; BBUNSUP($1, "Unsupported: expect"); DEL($3, $5, $7); }
| yEXPECT '(' property_spec ')' yELSE stmt
{ $$ = nullptr; BBUNSUP($1, "Unsupported: expect"); DEL($6); }
{ $$ = nullptr; BBUNSUP($1, "Unsupported: expect"); DEL($3, $6); }
;
statementVerilatorPragmas<pragmap>:
@ -6642,7 +6642,7 @@ property_exprCaseIf<nodeExprp>: // IEEE: part of property_expr for if/case
| yIF '(' expr/*expression_or_dist*/ ')' pexpr %prec prLOWER_THAN_ELSE
{ $$ = $5; BBUNSUP($<fl>1, "Unsupported: property case expression"); DEL($3); }
| yIF '(' expr/*expression_or_dist*/ ')' pexpr yELSE pexpr
{ $$ = $5; BBUNSUP($<fl>1, "Unsupported: property case expression"); DEL($7); }
{ $$ = $5; BBUNSUP($<fl>1, "Unsupported: property case expression"); DEL($3, $7); }
;
property_case_itemList<caseItemp>: // IEEE: {property_case_item}