luke
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use AstClass::isClassExtendedFrom instead of local isSubclassOf helper

This commit is contained in:
Yilou Wang 2026-06-18 13:50:26 +02:00
parent 1f6280032c
commit 425379eec7
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/V3Randomize.cpp
View File

@ -3770,12 +3770,6 @@ class RandomizeVisitor final : public VNVisitor {
funcp->addStmtsp(callp->makeStmt()); funcp->addStmtsp(callp->makeStmt());
} }
} }
static bool isSubclassOf(AstClass* classp, const AstClass* const basep) {
for (AstClass* cp = classp; cp; cp = cp->extendsp() ? cp->extendsp()->classp() : nullptr) {
if (cp == basep) return true;
}
return false;
}
// Per-class virtual wrapper that invokes the class's effective // Per-class virtual wrapper that invokes the class's effective
// pre_randomize/post_randomize. IEEE 1800-2023 18.6.2: pre_randomize and // pre_randomize/post_randomize. IEEE 1800-2023 18.6.2: pre_randomize and
// post_randomize "appear to behave as virtual methods" because randomize() // post_randomize "appear to behave as virtual methods" because randomize()
@ -3804,7 +3798,7 @@ class RandomizeVisitor final : public VNVisitor {
if (cachedIt != m_prePostWrap.end()) return cachedIt->second; if (cachedIt != m_prePostWrap.end()) return cachedIt->second;
std::vector<AstClass*> hierp{classp}; std::vector<AstClass*> hierp{classp};
v3Global.rootp()->foreach([&](AstClass* subp) { v3Global.rootp()->foreach([&](AstClass* subp) {
if (subp != classp && isSubclassOf(subp, classp)) hierp.push_back(subp); if (subp != classp && AstClass::isClassExtendedFrom(subp, classp)) hierp.push_back(subp);
}); });
bool hasPre = false; bool hasPre = false;
bool hasPost = false; bool hasPost = false;

2
test_regress/t/t_randomize_prepost_with_baseref.v
View File

@ -72,7 +72,7 @@ module t;
b = d; b = d;
ok = b.randomize() with {a == 8'h3c;}; ok = b.randomize() with {a == 8'h3c;};
`checkd(ok, 1); `checkd(ok, 1);
`checkd(d.a, 8'h3c); `checkd(b.a, 8'h3c);
`checkd(d.m_pre, 8'd10); `checkd(d.m_pre, 8'd10);
`checkd(d.m_post, 8'h3d); `checkd(d.m_post, 8'h3d);