Fix Codacy warnings. No functional change.

This commit is contained in:
Wilson Snyder 2021-07-07 19:42:49 -04:00
parent 36599133bf
commit 3aa6332f25
3 changed files with 28 additions and 18 deletions

View File

@ -1,16 +1,25 @@
/*Verilator blue #008fd7; set in html*/ /* Verilator blue #008fd7; set in html */
.wy-side-nav-search > div.version { .wy-side-nav-search > div.version {
color: #111; color: #111;
} }
.fa-github::before, .icon-github::before {
content: ""; .fa-github::before,
.icon-github::before {
content: "";
} }
.fa-home::before, .icon-home::before {
content: ""; .fa-home::before,
.icon-home::before {
content: "";
} }
.fa-arrow-circle-right::before, .icon-circle-arrow-right::before {
content: ""; .fa-arrow-circle-right::before,
.icon-circle-arrow-right::before {
content: "";
} }
.fa-arrow-circle-left::before, .icon-circle-arrow-left::before {
content: ""; .fa-arrow-circle-left::before,
.icon-circle-arrow-left::before {
content: "";
} }

View File

@ -1458,10 +1458,10 @@ void AstRefDType::dump(std::ostream& str) const {
if (!s_recursing) { // Prevent infinite dump if circular typedefs if (!s_recursing) { // Prevent infinite dump if circular typedefs
s_recursing = true; s_recursing = true;
str << " -> "; str << " -> ";
if (typedefp()) { if (const auto subp = typedefp()) {
typedefp()->dump(str); subp->dump(str);
} else if (subDTypep()) { } else if (const auto subp = subDTypep()) {
subDTypep()->dump(str); subp->dump(str);
} }
s_recursing = false; s_recursing = false;
} }
@ -1506,7 +1506,8 @@ void AstNodeArrayDType::dump(std::ostream& str) const {
} }
string AstPackArrayDType::prettyDTypeName() const { string AstPackArrayDType::prettyDTypeName() const {
std::ostringstream os; std::ostringstream os;
os << subDTypep()->prettyDTypeName() << declRange(); if (const auto subp = subDTypep()) os << subp->prettyDTypeName();
os << declRange();
return os.str(); return os.str();
} }
string AstUnpackArrayDType::prettyDTypeName() const { string AstUnpackArrayDType::prettyDTypeName() const {

View File

@ -133,10 +133,10 @@ void V3GraphVertex::v3errorEnd(std::ostringstream& str) const {
nsstr << endl; nsstr << endl;
nsstr << "-vertex: " << this << endl; nsstr << "-vertex: " << this << endl;
} }
if (!fileline()) { if (FileLine* const flp = fileline()) {
V3Error::v3errorEnd(nsstr); flp->v3errorEnd(nsstr);
} else { } else {
fileline()->v3errorEnd(nsstr); V3Error::v3errorEnd(nsstr);
} }
} }
void V3GraphVertex::v3errorEndFatal(std::ostringstream& str) const { void V3GraphVertex::v3errorEndFatal(std::ostringstream& str) const {