Add error on class extending itself

src/V3LinkDot.cpp

@@ -2774,15 +2774,20 @@ private:
                             if (AstClass* classp = VN_CAST(foundp->nodep(), Class)) {
                                 UINFO(8, "Import to " << nodep << " from export class " << classp
                                                       << endl);
-                                AstClassRefDType* newp
+                                if (classp == nodep) {
-                                    = new AstClassRefDType{nodep->fileline(), classp};
+                                    cextp->v3error("Attempting to extend class "
-                                cextp->childDTypep(newp);
+                                                   << nodep->prettyNameQ() << " from itself");
-                                classp->isExtended(true);
+                                } else {
-                                nodep->isExtended(true);
+                                    AstClassRefDType* newp
-                                VSymEnt* srcp = m_statep->getNodeSym(classp);
+                                        = new AstClassRefDType{nodep->fileline(), classp};
-                                m_curSymp->importFromClass(m_statep->symsp(), srcp);
+                                    cextp->childDTypep(newp);
-                                VL_DO_DANGLING(cpackagerefp->unlinkFrBack()->deleteTree(),
+                                    classp->isExtended(true);
-                                               cpackagerefp);
+                                    nodep->isExtended(true);
+                                    VSymEnt* srcp = m_statep->getNodeSym(classp);
+                                    m_curSymp->importFromClass(m_statep->symsp(), srcp);
+                                    VL_DO_DANGLING(cpackagerefp->unlinkFrBack()->deleteTree(),
+                                                   cpackagerefp);
+                                }
                                 ok = true;
                             }
                         }

test_regress/t/t_class_extends_rec_bad.out

@@ -0,0 +1,4 @@
+%Error: t/t_class_extends_rec_bad.v:7:31: Attempting to extend class 'RecursiveExtCls' from itself
+    7 | class RecursiveExtCls extends RecursiveExtCls;
+      |                               ^~~~~~~~~~~~~~~
+%Error: Exiting due to

test_regress/t/t_class_extends_rec_bad.pl

@@ -0,0 +1,19 @@
+#!/usr/bin/env perl
+if (!$::Driver) { use FindBin; exec("$FindBin::Bin/bootstrap.pl", @ARGV, $0); die; }
+# DESCRIPTION: Verilator: Verilog Test driver/expect definition
+#
+# Copyright 2020 by Wilson Snyder. This program is free software; you
+# can redistribute it and/or modify it under the terms of either the GNU
+# Lesser General Public License Version 3 or the Perl Artistic License
+# Version 2.0.
+# SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0
+
+scenarios(linter => 1);
+
+lint(
+    fails => 1,
+    expect_filename => $Self->{golden_filename},
+    );
+
+ok(1);
+1;

test_regress/t/t_class_extends_rec_bad.v

@@ -0,0 +1,13 @@
+// DESCRIPTION: Verilator: Verilog Test module
+//
+// This file ONLY is placed under the Creative Commons Public Domain, for
+// any use, without warranty, 2020 by Wilson Snyder.
+// SPDX-License-Identifier: CC0-1.0
+
+class RecursiveExtCls extends RecursiveExtCls;
+   int i;
+endclass
+
+module t (/*AUTOARG*/);
+   RecursiveExtCls cls = new;
+endmodule