Internals: Make the constant pool a regular package (#8512)

The constant pool is now an ordinary package, created with the netlist
and instantiated under $root like any other package, and most special
handling has been removed, including AstConstPool. Lookups go through
V3ConstPool, which has a singleton instance owned by V3Global. Static
methods on V3Common form the public interfce to add/find constant pool
entries.

With that, the constant pool is usable at any stage during compilation,
so enum and dimension tables created by V3Width, and enum value tables
created by V3Randomize now also live in the constant pool instead of
$unit, so identical tables are shared.

Associative array constants are handled separately from unpacked
tables, which used to be broken but unused.

Emitted constant pool variables use direct initialization, and
`constinit` with C++20 where the type allows it. This ensures we don't
change a run-time in a way that would result in unintended code size
increase.

-fno-merge-const-pool, which was introduced years ago but never prompted
a bug report is deprecated and has no effect.

This is also prep for future work.

src/V3Subst.cpp

@@ -219,8 +219,6 @@ AstNodeExpr* SubstVarEntry::substRecord(SubstVarEntry::Record& record) {
 class SubstVisitor final : public VNVisitor {
     // NODE STATE - only Under AstCFunc
     // AstVar::user1p -> SubstVarEntry* for assignment tracking. Also used by SubstValidVisitor
-    // AstVar::user2  -> bool. Is a constant pool variable
-    const VNUser2InUse m_user2InUse;
 
     // STATE
     std::deque<SubstVarEntry> m_entries;  // Storage for SubstVarEntry instances
@@ -277,14 +275,7 @@ class SubstVisitor final : public VNVisitor {
 
     // VISITORS
 
-    void visit(AstNetlist* nodep) override {
-        // Mark constant pool variables
-        for (AstNode* np = nodep->constPoolp()->modp()->stmtsp(); np; np = np->nextp()) {
-            if (VN_IS(np, Var)) np->user2(true);
-        }
-
-        iterateAndNextNull(nodep->modulesp());
-    }
+    void visit(AstNetlist* nodep) override { iterateAndNextNull(nodep->modulesp()); }
 
     void visit(AstCFunc* nodep) override {
         UASSERT_OBJ(!m_funcp, nodep, "Should not nest");
@@ -378,7 +369,7 @@ class SubstVisitor final : public VNVisitor {
 
                 // If it's a constant pool variable, substiute with the constant word
                 AstVar* const varp = refp->varp();
-                if (varp->user2()) {
+                if (varp->constPoolEntry()) {
                     AstConst* const constp = VN_AS(varp->valuep(), Const);
                     const uint32_t value = constp->num().edataWord(word);
                     FileLine* const flp = nodep->fileline();