luke
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reset radix in width warnings (#5166)

This commit is contained in:
Geza Lore 2024-06-09 14:39:17 +01:00 committed by GitHub
parent d6bc0c712a
commit 29db25b70e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/V3Width.cpp
View File

@ -880,7 +880,7 @@ class WidthVisitor final : public VNVisitor {
const int width = nodep->elementsConst(); const int width = nodep->elementsConst();
if (width > (1 << 28)) { if (width > (1 << 28)) {
nodep->v3error("Width of bit range is huge; vector of over 1 billion bits: 0x" nodep->v3error("Width of bit range is huge; vector of over 1 billion bits: 0x"
<< std::hex << width); << std::hex << width << std::dec);
} }
// Note width() not set on range; use elementsConst() // Note width() not set on range; use elementsConst()
if (nodep->ascending() && !VN_IS(nodep->backp(), UnpackArrayDType) if (nodep->ascending() && !VN_IS(nodep->backp(), UnpackArrayDType)

14
test_regress/t/t_select_bad_range4.out
View File

@ -20,15 +20,15 @@
: ... note: In instance 't' : ... note: In instance 't'
21 | sel2 = mi[44 +: 1<<29]; 21 | sel2 = mi[44 +: 1<<29];
| ^ | ^
%Warning-SELRANGE: t/t_select_bad_range4.v:21:16: Extracting 20000000 bits from only 6 bit number %Warning-SELRANGE: t/t_select_bad_range4.v:21:16: Extracting 536870912 bits from only 6 bit number
: ... note: In instance 't' : ... note: In instance 't'
21 | sel2 = mi[44 +: 1<<29]; 21 | sel2 = mi[44 +: 1<<29];
| ^ | ^
%Warning-SELRANGE: t/t_select_bad_range4.v:21:16: Selection index out of range: 20000003:4 outside 2d:28 %Warning-SELRANGE: t/t_select_bad_range4.v:21:16: Selection index out of range: 536870915:4 outside 45:40
: ... note: In instance 't' : ... note: In instance 't'
21 | sel2 = mi[44 +: 1<<29]; 21 | sel2 = mi[44 +: 1<<29];
| ^ | ^
%Warning-WIDTHTRUNC: t/t_select_bad_range4.v:21:12: Operator ASSIGN expects 4 bits on the Assign RHS, but Assign RHS's SEL generates 20000000 bits. %Warning-WIDTHTRUNC: t/t_select_bad_range4.v:21:12: Operator ASSIGN expects 4 bits on the Assign RHS, but Assign RHS's SEL generates 536870912 bits.
: ... note: In instance 't' : ... note: In instance 't'
21 | sel2 = mi[44 +: 1<<29]; 21 | sel2 = mi[44 +: 1<<29];
| ^ | ^
@ -44,7 +44,7 @@
: ... note: In instance 't' : ... note: In instance 't'
22 | sel2 = mi[44 +: nonconst]; 22 | sel2 = mi[44 +: nonconst];
| ^ | ^
%Warning-WIDTHEXPAND: t/t_select_bad_range4.v:23:17: Operator SUB expects 20 or 6 bits on the LHS, but LHS's VARREF 'nonconst' generates 1 bits. %Warning-WIDTHEXPAND: t/t_select_bad_range4.v:23:17: Operator SUB expects 32 or 6 bits on the LHS, but LHS's VARREF 'nonconst' generates 1 bits.
: ... note: In instance 't' : ... note: In instance 't'
23 | sel2 = mi[nonconst]; 23 | sel2 = mi[nonconst];
| ^~~~~~~~ | ^~~~~~~~
@ -64,15 +64,15 @@
: ... note: In instance 't' : ... note: In instance 't'
24 | sel2 = mi[nonconst : nonconst]; 24 | sel2 = mi[nonconst : nonconst];
| ^ | ^
%Warning-SELRANGE: t/t_select_bad_range4.v:25:16: Extracting 20000001 bits from only 6 bit number %Warning-SELRANGE: t/t_select_bad_range4.v:25:16: Extracting 536870913 bits from only 6 bit number
: ... note: In instance 't' : ... note: In instance 't'
25 | sel2 = mi[1<<29 : 0]; 25 | sel2 = mi[1<<29 : 0];
| ^ | ^
%Warning-SELRANGE: t/t_select_bad_range4.v:25:16: Selection index out of range: 1fffffd8:ffffffd8 outside 2d:28 %Warning-SELRANGE: t/t_select_bad_range4.v:25:16: Selection index out of range: 536870872:-40 outside 45:40
: ... note: In instance 't' : ... note: In instance 't'
25 | sel2 = mi[1<<29 : 0]; 25 | sel2 = mi[1<<29 : 0];
| ^ | ^
%Warning-WIDTHTRUNC: t/t_select_bad_range4.v:25:12: Operator ASSIGN expects 4 bits on the Assign RHS, but Assign RHS's SEL generates 20000001 bits. %Warning-WIDTHTRUNC: t/t_select_bad_range4.v:25:12: Operator ASSIGN expects 4 bits on the Assign RHS, but Assign RHS's SEL generates 536870913 bits.
: ... note: In instance 't' : ... note: In instance 't'
25 | sel2 = mi[1<<29 : 0]; 25 | sel2 = mi[1<<29 : 0];
| ^ | ^