luke
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Address review 

Signed-off-by: Krzysztof Bieganski <kbieganski@antmicro.com>
This commit is contained in:
Krzysztof Bieganski 2025-03-04 15:24:03 +01:00
parent 69421afcdd
commit 23ad3bc8b9
3 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/V3AstNodeDType.h
View File

@ -51,7 +51,7 @@ protected:
private:
// METHODS
const AstNodeDType* skipRefIterp(bool skipConst, bool skipEnum,
bool assert = true) const VL_MT_STABLE;
bool assertOn = true) const VL_MT_STABLE;
protected:
// METHODS

4
src/V3AstNodes.cpp
View File

@ -830,7 +830,7 @@ AstVar* AstVar::scVarRecurse(AstNode* nodep) {
}
const AstNodeDType* AstNodeDType::skipRefIterp(bool skipConst, bool skipEnum,
bool assert) const VL_MT_STABLE {
bool assertOn) const VL_MT_STABLE {
const AstNodeDType* nodep = this;
while (true) {
if (VL_UNLIKELY(VN_IS(nodep, MemberDType) || VN_IS(nodep, ParamTypeDType)
@ -841,7 +841,7 @@ const AstNodeDType* AstNodeDType::skipRefIterp(bool skipConst, bool skipEnum,
nodep = subp;
continue;
} else {
if (assert) nodep->v3fatalSrc(nodep->prettyTypeName() << " not linked to type");
if (assertOn) nodep->v3fatalSrc(nodep->prettyTypeName() << " not linked to type");
return nullptr;
}
}

12
src/V3LinkDot.cpp
View File

@ -2762,7 +2762,7 @@ class LinkDotResolveVisitor final : public VNVisitor {
if (!lhsp->classOrPackageSkipp() && lhsp->name() != "local::") {
revisitLater(nodep);
m_ds = lastStates;
if (auto* ftaskrefp = VN_CAST(nodep->rhsp(), NodeFTaskRef)) {
if (AstNodeFTaskRef* const ftaskrefp = VN_CAST(nodep->rhsp(), NodeFTaskRef)) {
iterateAndNextNull(ftaskrefp->pinsp());
}
return;
@ -2771,7 +2771,8 @@ class LinkDotResolveVisitor final : public VNVisitor {
// nodep->lhsp() may be a new node
if (AstClassOrPackageRef* const classOrPackageRefp
= VN_CAST(nodep->lhsp(), ClassOrPackageRef)) {
if (AstNode* classOrPackageNodep = classOrPackageRefp->classOrPackageSkipp()) {
if (AstNode* const classOrPackageNodep
= classOrPackageRefp->classOrPackageSkipp()) {
m_ds.m_dotSymp = m_statep->getNodeSym(classOrPackageNodep);
}
}
@ -2787,7 +2788,8 @@ class LinkDotResolveVisitor final : public VNVisitor {
if (!crefp->classOrPackageSkipp()) {
revisitLater(nodep);
m_ds = lastStates;
if (auto* ftaskrefp = VN_CAST(nodep->rhsp(), NodeFTaskRef)) {
if (AstNodeFTaskRef* const ftaskrefp
= VN_CAST(nodep->rhsp(), NodeFTaskRef)) {
iterateAndNextNull(ftaskrefp->pinsp());
}
return;
@ -2795,7 +2797,7 @@ class LinkDotResolveVisitor final : public VNVisitor {
}
if (m_lastDeferredp == nodep->lhsp()) {
m_ds = lastStates;
if (auto* ftaskrefp = VN_CAST(nodep->rhsp(), NodeFTaskRef)) {
if (AstNodeFTaskRef* const ftaskrefp = VN_CAST(nodep->rhsp(), NodeFTaskRef)) {
iterateAndNextNull(ftaskrefp->pinsp());
}
return;
@ -4385,7 +4387,7 @@ public:
: m_statep{statep} {
UINFO(4, __FUNCTION__ << ": " << endl);
iterate(rootp);
auto modulesToRevisit = std::move(m_modulesToRevisit);
std::map<std::string, AstNodeModule*> modulesToRevisit = std::move(m_modulesToRevisit);
m_lastDeferredp = nullptr;
for (auto& p : modulesToRevisit) {
AstNodeModule* const modp = p.second;