Internals: Fix GCC8 cppcheck warnings. No functional change.

This commit is contained in:
Wilson Snyder
2018-02-07 20:16:53 -05:00
parent 32859d9fc2
commit 22573d238b
15 changed files with 24 additions and 21 deletions
+3 -5
View File
@@ -604,7 +604,7 @@ class LinkDotFindVisitor : public AstNVisitor {
// METHODS
int debug() { return LinkDotState::debug(); }
virtual AstConst* parseParamLiteral(FileLine* fl, string literal) {
virtual AstConst* parseParamLiteral(FileLine* fl, const string& literal) {
bool success = false;
if (literal[0] == '"') {
// This is a string
@@ -2110,10 +2110,8 @@ private:
}
dotSymp = m_statep->findDotted(dotSymp, nodep->dotted(), baddot, okSymp); // Maybe NULL
}
VSymEnt* foundp = NULL;
AstNodeFTask* taskp = NULL;
foundp = m_statep->findSymPrefixed(dotSymp, nodep->name(), baddot);
taskp = foundp ? foundp->nodep()->castNodeFTask() : NULL; // Maybe NULL
VSymEnt* foundp = m_statep->findSymPrefixed(dotSymp, nodep->name(), baddot);
AstNodeFTask* taskp = foundp ? foundp->nodep()->castNodeFTask() : NULL; // Maybe NULL
if (taskp) {
nodep->taskp(taskp);
nodep->packagep(foundp->packagep());