luke
/
verilator
mirror of https://github.com/verilator/verilator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Internals: Remove redundant hash lookup (#5276 partial) (#5303) 

Minor help for #5276
This commit is contained in:
Geza Lore 2024-07-25 21:07:58 +01:00 committed by GitHub
parent 87d1c10fa7
commit 0d43c14b93
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/V3Dfg.cpp
View File

@ -360,8 +360,8 @@ bool DfgVertex::equals(const DfgVertex& that, EqualsCache& cache) const {
const auto key = (this < &that) ? EqualsCache::key_type{this, &that} // const auto key = (this < &that) ? EqualsCache::key_type{this, &that} //
: EqualsCache::key_type{&that, this}; : EqualsCache::key_type{&that, this};
// Note: the recursive invocation can cause a re-hash of the cache which invalidates iterators // Note: the recursive invocation can cause a re-hash but that will not invalidate references
uint8_t result = cache[key]; uint8_t& result = cache[key];
if (!result) { if (!result) {
result = 2; // Assume equals result = 2; // Assume equals
auto thisPair = this->sourceEdges(); auto thisPair = this->sourceEdges();
@ -380,7 +380,6 @@ bool DfgVertex::equals(const DfgVertex& that, EqualsCache& cache) const {
break; break;
} }
} }
cache[key] = result;
} }
return result >> 1; return result >> 1;
} }