Internals: Remove ordering before MTask contraction (#8019)

As the removed comment suggests, this is dubious and RTLMeter suggests
it makes no measurable difference on average (some designs improve, some
regress small amounts, on average ~1.0x)

Prep for further fixes that will remove the pre ranking.
This commit is contained in:
Geza Lore 2026-08-03 10:44:51 +01:00 committed by GitHub
parent a24dd8b2dc
commit 0750e18ad0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 12 deletions

View File

@ -52,18 +52,6 @@ static std::unique_ptr<OrderMTaskGraph> partition(OrderMoveGraph& moveGraph) {
OrderMTaskGraph::fixDataHazards(*mTaskGraphp);
mTaskGraphp->hashGraphDebug("MTask graph after fixDataHazards()");
// Order the graph. We know it's already ranked from fixDataHazards() so we don't need to rank
// it again.
//
// On at least some models, ordering the graph here seems to help performance. (Why? Is it just
// triggering noise in a lucky direction? Is it just as likely to harm results?)
//
// More diversity of models that can build with --threads will eventually tell us. For now keep
// the order() so we don't forget about it, in case it actually helps. TODO: get more data and
// maybe remove this later if it doesn't really help.
mTaskGraphp->orderPreRanked();
mTaskGraphp->hashGraphDebug("MTask graph after orderPreRanked()");
// Merge MTask nodes together, repeatedly, until the critical path budget is reached. Coarsens
// the graph, usually by several orders of magnitude. Some tests disable this for stability,
// it should always be enabled in production.