luke/verilator
1
0
Fork 0
mirror of https://github.com/verilator/verilator.git synced 2026-08-22 05:57:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix try-lock spuriously fails (#4931) (#4938)

Browse Source
This commit is contained in:
Kamil Rakoczy
2024-03-01 15:29:13 -05:00
committed by GitHub
parent 9dcb7ea6a9
commit 01dadb0a8d
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/V3ThreadPool.h
+9 -1
View File
@@ -139,7 +139,15 @@ class V3ThreadPool final {
std::abort(); std::abort();
} }
if (VL_UNCOVERABLE(!m_mutex.try_lock())) { bool m_mutex_locked = m_mutex.try_lock();
// try_lock can sometimes spontaneously fail even when mutex is not locked,
// make sure this isn't the case
for (int i = 0; i < VL_LOCK_SPINS; ++i) {
if (VL_LIKELY(m_mutex_locked)) break;
VL_CPU_RELAX();
m_mutex_locked = m_mutex.try_lock();
}
if (VL_UNCOVERABLE(!m_mutex_locked)) {
if (VL_UNCOVERABLE(m_jobsInProgress != 0)) { if (VL_UNCOVERABLE(m_jobsInProgress != 0)) {
// ThreadPool shouldn't be destroyed when jobs are running and mutex is locked, // ThreadPool shouldn't be destroyed when jobs are running and mutex is locked,
// something is wrong. Most likely Verilator is exiting as a result of failed // something is wrong. Most likely Verilator is exiting as a result of failed