2024-03-02 20:49:29 +01:00
|
|
|
// -*- mode: C++; c-file-style: "cc-mode" -*-
|
|
|
|
|
//*************************************************************************
|
|
|
|
|
// DESCRIPTION: Verilator: Convert DfgGraph to AstModule
|
|
|
|
|
//
|
|
|
|
|
// Code available from: https://verilator.org
|
|
|
|
|
//
|
|
|
|
|
//*************************************************************************
|
|
|
|
|
//
|
2025-01-01 14:30:25 +01:00
|
|
|
// Copyright 2003-2025 by Wilson Snyder. This program is free software; you
|
2024-03-02 20:49:29 +01:00
|
|
|
// can redistribute it and/or modify it under the terms of either the GNU
|
|
|
|
|
// Lesser General Public License Version 3 or the Perl Artistic License
|
|
|
|
|
// Version 2.0.
|
|
|
|
|
// SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0
|
|
|
|
|
//
|
|
|
|
|
//*************************************************************************
|
|
|
|
|
//
|
|
|
|
|
// - Ensures intermediate values (other than simple memory references or
|
|
|
|
|
// constants) with multiple uses are assigned to variables
|
|
|
|
|
//
|
|
|
|
|
//*************************************************************************
|
|
|
|
|
|
|
|
|
|
#include "V3PchAstNoMT.h" // VL_MT_DISABLED_CODE_UNIT
|
|
|
|
|
|
|
|
|
|
#include "V3Dfg.h"
|
|
|
|
|
#include "V3DfgPasses.h"
|
|
|
|
|
|
|
|
|
|
VL_DEFINE_DEBUG_FUNCTIONS;
|
|
|
|
|
|
|
|
|
|
class DfgRegularize final {
|
|
|
|
|
DfgGraph& m_dfg; // The graph being processed
|
|
|
|
|
V3DfgRegularizeContext& m_ctx; // The optimization context for stats
|
|
|
|
|
|
2024-03-05 20:16:34 +01:00
|
|
|
// Prefix of temporary variable names
|
|
|
|
|
size_t m_nTmps = 0; // Number of temporaries added to this graph - for variable names only
|
2024-03-02 20:49:29 +01:00
|
|
|
|
|
|
|
|
// Insert intermediate variables for vertices with multiple sinks (or use an existing one)
|
|
|
|
|
DfgRegularize(DfgGraph& dfg, V3DfgRegularizeContext& ctx)
|
|
|
|
|
: m_dfg{dfg}
|
|
|
|
|
, m_ctx{ctx} {
|
|
|
|
|
|
2025-07-01 23:55:08 +02:00
|
|
|
// Scope cache for below
|
|
|
|
|
const bool scoped = !dfg.modulep();
|
|
|
|
|
DfgVertex::ScopeCache scopeCache;
|
|
|
|
|
|
2024-03-02 20:49:29 +01:00
|
|
|
// Ensure intermediate values used multiple times are written to variables
|
2024-03-26 00:06:25 +01:00
|
|
|
for (DfgVertex& vtx : m_dfg.opVertices()) {
|
2024-04-27 14:41:10 +02:00
|
|
|
const bool needsIntermediateVariable = [&]() {
|
Optimize complex combinational logic in DFG (#6298)
This patch adds DfgLogic, which is a vertex that represents a whole,
arbitrarily complex combinational AstAlways or AstAssignW in the
DfgGraph.
Implementing this requires computing the variables live at entry to the
AstAlways (variables read by the block), so there is a new
ControlFlowGraph data structure and a classical data-flow analysis based
live variable analysis to do that at the variable level (as opposed to
bit/element level).
The actual CFG construction and live variable analysis is best effort,
and might fail for currently unhandled constructs or data types. This
can be extended later.
V3DfgAstToDfg is changed to convert the Ast into an initial DfgGraph
containing only DfgLogic, DfgVertexSplice and DfgVertexVar vertices.
The DfgLogic are then subsequently synthesized into primitive operations
by the new V3DfgSynthesize pass, which is a combination of the old
V3DfgAstToDfg conversion and new code to handle AstAlways blocks with
complex flow control.
V3DfgSynthesize by default will synthesize roughly the same constructs
as V3DfgAstToDfg used to handle before, plus any logic that is part of a
combinational cycle within the DfgGraph. This enables breaking up these
cycles, for which there are extensions to V3DfgBreakCycles in this patch
as well. V3DfgSynthesize will then delete all non synthesized or non
synthesizable DfgLogic vertices and the rest of the Dfg pipeline is
identical, with minor changes to adjust for the changed representation.
Because with this change we can now eliminate many more UNOPTFLAT, DFG
has been disabled in all the tests that specifically target testing the
scheduling and reporting of circular combinational logic.
2025-08-19 16:06:38 +02:00
|
|
|
// Splice vertices represent partial assignments. The must flow
|
|
|
|
|
// into variables, so they should never need a temporary.
|
|
|
|
|
if (vtx.is<DfgVertexSplice>()) return false;
|
|
|
|
|
// Smilarly to splice, UnitArray should never need one eitehr
|
|
|
|
|
if (vtx.is<DfgUnitArray>()) return false;
|
2024-04-27 14:41:10 +02:00
|
|
|
// Operations without multiple sinks need no variables
|
|
|
|
|
if (!vtx.hasMultipleSinks()) return false;
|
|
|
|
|
// Array selects need no variables, they are just memory references
|
|
|
|
|
if (vtx.is<DfgArraySel>()) return false;
|
|
|
|
|
// Otherwise needs an intermediate variable
|
|
|
|
|
return true;
|
|
|
|
|
}();
|
|
|
|
|
|
|
|
|
|
if (!needsIntermediateVariable) continue;
|
2024-03-02 20:49:29 +01:00
|
|
|
|
2025-06-16 13:25:44 +02:00
|
|
|
// This is an op that requires a result variable. Ensure it is
|
|
|
|
|
// assigned to one, and redirect other sinks read that variable.
|
2025-07-14 23:09:34 +02:00
|
|
|
if (DfgVertexVar* const varp = vtx.getResultVar()) {
|
2025-09-02 17:50:40 +02:00
|
|
|
varp->srcp(nullptr);
|
2024-03-26 00:06:25 +01:00
|
|
|
vtx.replaceWith(varp);
|
2025-07-14 23:09:34 +02:00
|
|
|
varp->srcp(&vtx);
|
2024-03-02 20:49:29 +01:00
|
|
|
} else {
|
2025-06-16 13:25:44 +02:00
|
|
|
// Need to create an intermediate variable
|
|
|
|
|
const std::string name = m_dfg.makeUniqueName("Regularize", m_nTmps);
|
|
|
|
|
FileLine* const flp = vtx.fileline();
|
2025-07-01 23:55:08 +02:00
|
|
|
AstScope* const scopep = scoped ? vtx.scopep(scopeCache) : nullptr;
|
2025-07-14 23:09:34 +02:00
|
|
|
DfgVertexVar* const newp = m_dfg.makeNewVar(flp, name, vtx.dtypep(), scopep);
|
2025-06-16 13:25:44 +02:00
|
|
|
++m_nTmps;
|
|
|
|
|
++m_ctx.m_temporariesIntroduced;
|
|
|
|
|
// Replace vertex with the variable and add back driver
|
|
|
|
|
vtx.replaceWith(newp);
|
2025-07-14 23:09:34 +02:00
|
|
|
newp->srcp(&vtx);
|
2024-03-02 20:49:29 +01:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public:
|
|
|
|
|
static void apply(DfgGraph& dfg, V3DfgRegularizeContext& ctx) { DfgRegularize{dfg, ctx}; }
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
void V3DfgPasses::regularize(DfgGraph& dfg, V3DfgRegularizeContext& ctx) {
|
|
|
|
|
DfgRegularize::apply(dfg, ctx);
|
|
|
|
|
}
|