luke
/
sv2v
mirror of https://github.com/zachjs/sv2v.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

clearer messaging surrounding unsupported interface conversion features

This commit is contained in:
Zachary Snow 2019-04-17 01:44:03 -04:00
parent 8b8d62c6e2
commit 07b64bd1f2
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/Convert/Interface.hs
View File

@ -70,7 +70,6 @@ convertDescription interfaces modules (Part extern Module lifetime name ports it
else return () else return ()
collectInterface _ = return () collectInterface _ = return ()
-- TODO: We don't yet handle interfaces with parameter bindings.
mapInterface :: ModuleItem -> ModuleItem mapInterface :: ModuleItem -> ModuleItem
mapInterface (orig @ (MIDecl (Variable Local t ident _ _))) = mapInterface (orig @ (MIDecl (Variable Local t ident _ _))) =
case Map.lookup ident modports of case Map.lookup ident modports of
@ -86,8 +85,13 @@ convertDescription interfaces modules (Part extern Module lifetime name ports it
mapInterface (Instance part params ident Nothing instancePorts) = mapInterface (Instance part params ident Nothing instancePorts) =
case Map.lookup part interfaces of case Map.lookup part interfaces of
Just interface -> Just interface ->
Generate $ map GenModuleItem $ -- TODO: Add support for interfaces with parameter bindings.
inlineInterface interface (ident, expandedPorts) if not $ null params
then error $ "interface instantiations with parameter "
++ "bindings are not yet supported: "
++ show (part, params, ident)
else Generate $ map GenModuleItem $
inlineInterface interface (ident, expandedPorts)
Nothing -> Instance part params ident Nothing expandedPorts Nothing -> Instance part params ident Nothing expandedPorts
where expandedPorts = concatMap (expandPortBinding part) instancePorts where expandedPorts = concatMap (expandPortBinding part) instancePorts
mapInterface (orig @ (MIPackageItem (Function _ _ _ decls _))) = mapInterface (orig @ (MIPackageItem (Function _ _ _ decls _))) =
@ -197,8 +201,6 @@ prefixModuleItems prefix =
prefixLHS (LHSIdent x) = LHSIdent (prefix ++ x) prefixLHS (LHSIdent x) = LHSIdent (prefix ++ x)
prefixLHS other = other prefixLHS other = other
-- TODO: this is an incomplete attempt at looking up the type of an expression;
-- there is definitely some overlap here with the Struct conversion
lookupType :: [ModuleItem] -> Expr -> Type lookupType :: [ModuleItem] -> Expr -> Type
lookupType items (Ident ident) = lookupType items (Ident ident) =
head $ mapMaybe findType items head $ mapMaybe findType items
@ -207,7 +209,10 @@ lookupType items (Ident ident) =
findType (MIDecl (Variable _ t x [] Nothing)) = findType (MIDecl (Variable _ t x [] Nothing)) =
if x == ident then Just t else Nothing if x == ident then Just t else Nothing
findType _ = Nothing findType _ = Nothing
lookupType _ expr = error $ "lookupType on fancy expr: " ++ show expr lookupType _ expr =
-- TODO: Add support for non-Ident modport expressions.
error $ "interface conversion does not support modport expressions that "
++ " are not identifiers: " ++ show expr
-- convert an interface instantiation into a series of equivalent module items -- convert an interface instantiation into a series of equivalent module items
inlineInterface :: Interface -> (Identifier, [PortBinding]) -> [ModuleItem] inlineInterface :: Interface -> (Identifier, [PortBinding]) -> [ModuleItem]