mirror of https://github.com/sbt/sbt.git
4ed16c96ce
**Problem** Test is based on https://github.com/sbt/sbt/issues/9345#issuecomment-4718229113 which gives us the following sequence: 1. Metals sends buildTarget/compile. 2. sbt publishes real non-empty diagnostics. 3. Metals sends buildTarget/scalaMainClasses. 4. During that request, sbt emits build/publishDiagnostics with diagnostics: [] and reset: true. 5. The following build/taskFinish still reports errors: 1. Previously, errors for diagnostics reporting via bsp were collected from a live compilation run. In the sequence above, that is triggered by buildTarget/compile. Then, buildTarget/scalaMainClasses does not trigger such a run for the second time, it uses the cached compilation result. Therefore, the diagnostics is not populated. **Solution** The proposed fix modifies sendFailureReport to accept an optional CompileFailed object that contains the diagnostics even in case the actual compiler did not run because the cached result was used. If no problems were found for a file via default means, this CompileFailed object is queried to see if it has any information about problems in a given file. |
||
|---|---|---|
| .. | ||
| AbstractServerTest.scala | ||
| BuildServerTest.scala | ||
| ChannelCursorTest.scala | ||
| ClientSubscriptionTest.scala | ||
| ClientTest.scala | ||
| EventsTest.scala | ||
| HandshakeTest.scala | ||
| QueuedNotificationTest.scala | ||
| ResponseTest.scala | ||
| ServerCompletionsTest.scala | ||