mirror of https://github.com/sbt/sbt.git
A number of users were reporting issues with deadlocking when using 1.3.2: https://github.com/sbt/sbt/issues/5116. This seems to be because most of the sbt created classloaders were not actually parallel capable. In order for a classloader to be registered as a parallel capable, ALL of the parent classes except for object in the class hierarchy must be registered as a parallel capable: https://docs.oracle.com/javase/8/docs/api/java/lang/ClassLoader.html#registerAsParallelCapable--. If a classloader is not registered as parallel capable, then a global lock will be used internally for classloading and this can lead to deadlock. It is impossible to register a scala 2 classloader as parallel capable so I ported all of the classloaders to java. This commit updates the java-serialization scripted test. Prior to the port, the new version of the test would more or less always deadlock. After this change, I haven't been able to reproduce a deadlock. This had no significant performance impact when I reran https://github.com/eatkins/scala-build-watch-performance |
||
|---|---|---|
| .. | ||
| src | ||
| NOTICE | ||