mirror of https://github.com/sbt/sbt.git
b11adb6a88
NetworkChannel batches writes to the client at most once per 20ms to reduce terminal flicker and byte volume. forceFlush(), used to order buffered stdout ahead of a control-plane message, called flushExecutor.shutdownNow() -- the only place the executor was ever shut down. Once it ran during active output it tore the executor down (and, if a coalesced flush was pending, cancelled its future without resetting flushFuture, leaving the slot stuck), so the 20ms coalescing was gone for the rest of the connection: stdout was then flushed per write via the inline fallback instead of batched. Output still reaches the client, so the effect is extra flushes rather than lost output, but shutting the shared executor down on the first forceFlush is clearly unintended. Extract the flush state machine into CoalescingFlusher. forceFlush now drains immediately and leaves the timer live (a pending coalesced drain harmlessly drains the remainder when it fires); the executor is shut down once, at channel teardown, so it no longer leaks. doFlush now holds a lock across both the drain and the publish so an inline forceFlush and the timer's drain can't deliver two stdout batches out of order. Fixes #9415 Co-authored-by: Claude Fable 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| boot-socket-liveness.md | ||
| cache-version.md | ||
| dependency-tree-dedup.md | ||
| migration.md | ||
| missing-file-error.md | ||
| output-flush-coalescing.md | ||
| parallel-dependency-resolution.md | ||
| parallel-resolution-supershell.md | ||
| patterns-maven-compatible-default.md | ||
| remote-project-update.md | ||