Commit Graph

5624 Commits

Author SHA1 Message Date
Grzegorz Kossakowski 2a98355c64 Test for missing dependencies of macro arguments
Add a test which shows the problem of not properly capturing dependencies
of macro arguments.
2014-03-19 22:14:58 +01:00
Dan Sanduleac 6588ac1b62 sbtTransformHash -> e:sbtTransformHash 2014-03-19 11:08:17 +00:00
Josh Suereth fd860e0d3a Merge pull request #1189 from jroper/project-add-plugins
Allow end users to add Plugins, not just AutoPlugins
2014-03-19 00:12:00 -04:00
James Roper 9f20f04e16 Allow end users to add Plugins, not just AutoPlugins
This allows plugins to define a Plugins instance that captures both the
plugin and its required dependencies.

Also fixed up some scaladocs that were wrong.
2014-03-18 19:49:38 +11:00
Havoc Pennington a006235644 Merge pull request #1177 from sbt/wip/issue-1176
When fragmenting Defaults, we mixed back settings in the wrong order.
2014-03-12 09:13:58 -04:00
Josh Suereth 7c15eb01f3 When fragmenting Defaults, we mixed back settings in the wrong order.
* packageArtifacts is not cleared by defautlSettings
* Added a test for this behavior (this one test should ensure the ordering for most settings is correct.)

Fixes #1176
2014-03-12 08:50:37 -04:00
Havoc Pennington ad0ca70757 Merge pull request #1174 from sbt/wip/release-notes-0.13.2
Add changes documentation for 0.13.1->0.13.2
2014-03-11 13:44:18 -04:00
Josh Suereth fbffdb6551 Add changes documentation for 0.13.1->0.13.2 2014-03-11 13:20:38 -04:00
Havoc Pennington ae874ab0e1 Merge pull request #1173 from sbt/wip/more-architecture
Add introduction to the setting system
2014-03-11 12:52:13 -04:00
Josh Suereth 152e04bc05 Fix spelling issues in architecture document. 2014-03-11 12:47:42 -04:00
Josh Suereth ee6b674966 Add introduction to the setting system. 2014-03-11 11:45:00 -04:00
Josh Suereth 905028a6ae Bump version for further 0.13.x development. 2014-03-11 10:25:18 -04:00
Josh Suereth e30bc1b72f Merge pull request #1170 from sbt/wip/missing-test-fixes
Fixes missing tests from autoplugins feature.
2014-03-11 08:30:14 -04:00
Josh Suereth dc76a8feb3 Fixes missing tests from autoplugins feature.
For some reason, autoSettings fixes for tests disappeared.

* Fixes setting orderings now that defaults come from autoPlugins
* Removes autoPlugin settings where expected.
2014-03-10 23:49:09 -04:00
Josh Suereth c2f61460c6 Merge pull request #1169 from sbt/wip/fix-override-default
Fix overwrite default to true in deprecated method calls.
2014-03-10 17:17:49 -04:00
Havoc Pennington 37cc659518 Merge pull request #1165 from sbt/wip/auto-plugins-defaults
Use AutoPlugins for default project settings.
2014-03-10 17:11:07 -04:00
Josh Suereth 7413fbe9c0 Doc fix ups from review.
* Fix plugin mispellings
* Clarify `select` behavior.
2014-03-10 16:12:05 -04:00
Josh Suereth af25df1777 Fix @retronym's comments
* Fill out more details in archiecture section.
* Leave sections blank we don't have time to write.
* Consolidate on `Sub project` vernacular instead of module.
* Add a few examples to make statements concrete.
2014-03-10 14:22:56 -04:00
Josh Suereth 041bc4bf01 Add documentation for AddSettigns and load ordering.
* Add Architecture setting.
* Cover how settings are loaded and ordered
* Show basic controls on setting ordreing.
2014-03-10 12:45:35 -04:00
Josh Suereth 893794a8ba Fix overwrite default to true in deprecated method calls.
We cannot break existing users, but we can deprecate the improper usage.
This is part #2 of the workaround for #1156.  This ensures that
users will stop using the legacy methods after 0.13.2 is out.
2014-03-10 10:44:38 -04:00
Josh Suereth 548b38c7f8 Add note about not exposing fine-grained autoplugin inclusion controlls.
AddSettings should only expose coarse-grained features of AutoPlugins
or else the Logic we use to ensure safe addition completely breaks
down.  Leaving it in the code as an escape hatch if we get desparate,
but we need an alternative for controlling ordering later.
2014-03-10 09:45:25 -04:00
Josh Suereth ea8c0b32a7 Update documentation for AutoPlugins.
* Add notes about AutoPlugins vs. RootPlugins in Plugins section
* Modify best practices section to recomend using AutoPlugins.
* Modify Using-Plugins section in getting started to denote
  auto plugins.
2014-03-10 09:45:25 -04:00
Josh Suereth 01bb7ce2fd Remove defaultSettings usage from the docs.
Given the addition/promotion of AutoPlugins, remove
the references to the previously necessary
Defaults.defaultSettings method.
2014-03-10 09:45:25 -04:00
Josh Suereth 3576baa76c Split Defaults.scala into three plugins: Global,Ivy,Jvm.
* GlobalPlugin has defaults for controlling parallelism on tasks, basic command stuff.
* IvyModule has the configuration for resolving/publishing modules to ivy, assuming
  each project is a single module.
* JvmModule has the configuration for compiling/running/testing/packaging Java/Scala
  projects.
2014-03-10 09:45:25 -04:00
Josh Suereth a44a14f2c8 AutoPlugins appropriately participate in AddSettings.
* Add new AutoPlugins type to AddSettings.
* Ensure any Plugins filter doesn't just automatically always add
  autoplugins every time.
* Load.scala can now adjust AutoPlugins ordering

Note: Adjusting autoplugin ordering is dangerous BUT doing a glob
      of "put autoplugin settings here" is generally ok.
2014-03-10 09:45:25 -04:00
Josh Suereth ac9391066b Allow Build.scala project settings to be ordered via AddSettings.
* Create new AddSettings.ProjectSettings that can be used in the Addsettings order.
* Update Load.scala to correctly abide by AddSettings orderings.
2014-03-10 09:45:25 -04:00
Josh Suereth 7f8d21c2f1 Remove Natures from AutoPlugins feature.
* remove the notion of Natures from Autoplugins.
* Update tests to use AutoPlugins with no selection for inclusion.
* Rename exisitng Natures code to Plugins/PluginsDebug.
2014-03-10 09:45:25 -04:00
Josh Suereth 4dd4d670d7 Merge pull request #1168 from retronym/ticket/1107
Fix NPE in task macro accessing q"{...}".symbol.pos
2014-03-10 08:38:23 -04:00
Josh Suereth 75282195f4 Merge pull request #1168 from retronym/ticket/1107
Fix NPE in task macro accessing q"{...}".symbol.pos
2014-03-10 08:38:23 -04:00
Jason Zaugg f66830eed9 Fix NPE in task macro accessing q"{...}".symbol.pos
We shouldn't assume that the qualifier of a `Select` is a
`SymTree`; it may be a `Block`. One place that happens
is after the transformation of named/defaults applications.
That causes the reported `NullPointerException'.

In any case, using `qual.symbol.pos` sense here; it yields the
position of the defintions *referred to* by `qual`, not the
position of `qual` itself.

Both problems are easily fixed: use `qual.pos` instead.

Fixes #1107
2014-03-10 10:28:19 +01:00
Jason Zaugg af7eca1080 Fix NPE in task macro accessing q"{...}".symbol.pos
We shouldn't assume that the qualifier of a `Select` is a
`SymTree`; it may be a `Block`. One place that happens
is after the transformation of named/defaults applications.
That causes the reported `NullPointerException'.

In any case, using `qual.symbol.pos` sense here; it yields the
position of the defintions *referred to* by `qual`, not the
position of `qual` itself.

Both problems are easily fixed: use `qual.pos` instead.

Fixes #1107
2014-03-10 10:28:19 +01:00
Josh Suereth c398b1bf64 Merge pull request #1166 from retronym/ticket/1150
Fix task macro's handling of Symbol owners in <qual>.value
2014-03-09 09:48:33 -04:00
Josh Suereth 361c34324e Merge pull request #1166 from retronym/ticket/1150
Fix task macro's handling of Symbol owners in <qual>.value
2014-03-09 09:48:33 -04:00
Jason Zaugg ef826584c2 Fix task macro's handling of Symbol owners in <qual>.value
The qualifier of the `.value` call may contain `DefTree`s (e.g.
vals, defs) or `Function` trees. When we snip them out of the
tree and graft them into a new context, we must also call
`changeOwner`, so that the symbol owner structure and the tree
structure are coherent.

Failure to do so resulted in a crash in the compiler backend.

Fixes #1150
2014-03-09 12:20:24 +01:00
Jason Zaugg 563415aa6a Fix task macro's handling of Symbol owners in <qual>.value
The qualifier of the `.value` call may contain `DefTree`s (e.g.
vals, defs) or `Function` trees. When we snip them out of the
tree and graft them into a new context, we must also call
`changeOwner`, so that the symbol owner structure and the tree
structure are coherent.

Failure to do so resulted in a crash in the compiler backend.

Fixes #1150
2014-03-09 12:20:24 +01:00
Josh Suereth b02248a560 Merge pull request #1160 from sbt/wip/issue-1156
Don't fail publishing on overwrite, but issue a warning.
2014-03-08 16:03:50 -05:00
Josh Suereth 5b7ea8d93f Merge pull request #1158 from sbt/wip/issue-1155
Updates `last` and `export` commands to read from correct key.
2014-03-08 15:50:43 -05:00
Josh Suereth dbb47b3ce8 Updates `last` and `export` commands to read from correct key.
Fixes #1155.

It seems that somehow during the 0.13.{1 -> 2 } transition, we
stopped pointing at the correct key for TaskKeys (either that or
task streams are now all associated with the `streams` key).  I
think this may have been inadvertently caused from several
refactorings to enable greater control over the execution of tasks.

This points the `last*` methods at the correct key for tasks,
fixing both `last <key>` and `export <key>` commands.
2014-03-08 14:09:44 -05:00
Josh Suereth 875562f3db Don't fail publishing on overwrite, but issue a warning.
Workaround for #1156.

* Creates a new FileRepository that will stil allow local files
  to be transfered if overwrite is true (non-snapshot module),
  but will issue a warning about deprecated behavior.
* Ensure warning is long enough to annoy people into asking
  what it's about.
2014-03-08 14:08:25 -05:00
Josh Suereth 1626226b06 Merge pull request #1162 from sbt/wip/fix-deprecated-ivy-in-test
Removing deprecated "re-publish release artifacts" behavior from tests.
2014-03-08 13:07:32 -05:00
Josh Suereth 4a7f5aa92f Split scripted tests into matrix so we run on parallel virtual machines. 2014-03-08 10:50:33 -05:00
Josh Suereth c09c78a9b5 For now only run integration tests from travis (OoM errors). 2014-03-08 10:22:03 -05:00
Josh Suereth bc067694ae Merge branch 'wip/travis-test' into wip/fix-deprecated-ivy-in-test 2014-03-08 10:08:07 -05:00
Josh Suereth 56232e2025 First attempt at travis-ci integration for sbt. 2014-03-08 10:07:17 -05:00
Josh Suereth dff52ce11e Removing deprecated "re-publish release artifacts" behavior from tests.
In sbt 1.0 republishing released artifacts will be removed, causing these tests
to fail.  We migrate to SNAPSHOT version now, to prevent suprises.
2014-03-08 09:30:23 -05:00
Josh Suereth 84b79f9bc1 Revert "Fix task macro's handling of Symbol owners in <qual>.value"
This reverts commit 3017bfcd07.

This was causing sbt to be unable to compile.  Reverting temporarily until
we have a shot at a full fix.
2014-03-07 22:25:29 -05:00
Josh Suereth a4b288f35b Revert "Fix task macro's handling of Symbol owners in <qual>.value"
This reverts commit 3017bfcd07.

This was causing sbt to be unable to compile.  Reverting temporarily until
we have a shot at a full fix.
2014-03-07 22:25:29 -05:00
Josh Suereth ff6649b329 Merge pull request #1145 from sbt/wip/issue-1136
Fix #1136 - Ivy's + dependency ranges not converted appropriately to maven.
2014-03-07 17:22:29 -05:00
Josh Suereth f06948a4af Merge pull request #1145 from sbt/wip/issue-1136
Fix #1136 - Ivy's + dependency ranges not converted appropriately to maven.
2014-03-07 17:22:29 -05:00
Josh Suereth 1ed3daf169 Merge pull request #1157 from retronym/ticket/1150
Fix task macro's handling of Symbol owners in <qual>.value
2014-03-07 12:02:04 -05:00