Commit Graph

6268 Commits

Author SHA1 Message Date
eugene yokota 72556b28c7
Merge pull request #4119 from dwijnand/cleanup/contributing
Cleanup CONTRIBUTING.md
2018-04-25 13:22:21 -04:00
Dale Wijnand 952858e68b
Restore references to CONTRIBUTING, with checkbox 2018-04-25 17:08:41 +01:00
Dale Wijnand 8f76c48e63
Document sbtOn in CONTRIBUTING.md 2018-04-25 15:08:29 +01:00
Dale Wijnand 932ee5dc6a
Split support into SUPPORT.md
See https://help.github.com/articles/adding-support-resources-to-your-project/
2018-04-25 14:55:09 +01:00
Dale Wijnand 702ff1f516
Tweak Publishing VS Code Extensions 2018-04-25 14:51:19 +01:00
Dale Wijnand 2a4406717c
Move PROFILING out of CONTRIBUTING 2018-04-25 14:50:17 +01:00
Dale Wijnand 76a621b996
Not all PRs need notes 2018-04-25 14:50:17 +01:00
Dale Wijnand d7f66b0c00
Shuffle a part of issue reporting in CONTRIBUTING 2018-04-25 14:31:32 +01:00
Dale Wijnand 701eda668b
typo in CONTRIBUTING 2018-04-25 14:31:32 +01:00
Dale Wijnand 2a12a7aeb9
Fix section headers in CONTRIBUTING 2018-04-25 14:31:32 +01:00
Dale Wijnand f7d6cec030
Drop the references to the contributing guidelines from templates
I believe GitHub does a better job displaying this prominently,
particularly for first time contributors.

We can always bring back the pull request template if we have new content.
2018-04-25 14:31:15 +01:00
Dale Wijnand 2f880c6b8f
Merge support/contrib info into support/issues+prs sections of CONTRIBUTING 2018-04-25 14:13:12 +01:00
Dale Wijnand 8db585d62a
Refer to sbt/website instead of "the website project" in CONTRIBUTING 2018-04-25 14:12:17 +01:00
Dale Wijnand 564bbeab54
Merge pull request #4044 from dwijnand/cleanup/Resolve
Cleanup Resolve
2018-04-24 22:18:39 +01:00
Dale Wijnand 5f3b8c561c
Merge pull request #4064 from dwijnand/cleanup/formatting
Cleanup code formatting
2018-04-24 22:18:24 +01:00
Dale Wijnand a0e27c719c
Cleanup Resolve 2018-04-24 16:30:56 +01:00
Dale Wijnand ebe5540226
Reformat some corner cases 2018-04-24 16:12:18 +01:00
Dale Wijnand 8f4b8abb7b
Run scalafmt & test:scalafmt 2018-04-24 16:12:10 +01:00
Dale Wijnand aac916b119
Improve code clarity with danglingParentheses = true 2018-04-24 16:09:49 +01:00
Dale Wijnand cf1f65612a
Don't align args or params by the opening parens 2018-04-24 16:09:49 +01:00
Dale Wijnand 490f57c779
Upgrade to sbt-scalafmt 1.15 & scalafmt 1.4.0 2018-04-24 16:09:48 +01:00
Dale Wijnand 5bf1be1202
Merge pull request #4115 from dwijnand/cleanup/drop-negate-params-in-scalac-opts
Drop -Ywarn-unused:-params
2018-04-24 13:53:07 +01:00
Dale Wijnand c0756e14d9
Merge pull request #4114 from OlegYch/fix-4112
Remove usage of DynamicVariable and fix memory leak, fixes #4112
2018-04-24 09:53:39 +01:00
Dale Wijnand 065b65a05e
Drop -Ywarn-unused:-params
Previously we'd get in the build logs:

    [error] params cannot be negated, it enables other arguments

and lots of wawrnings.

Now we just get lots of warnings without the non-fatal error message.
2018-04-24 07:29:49 +01:00
OlegYch eeeb4c9ff2 Remove usage of DynamicVariable and fix memory leak, fixes https://github.com/sbt/sbt/issues/4112 2018-04-23 20:46:08 +03:00
Dale Wijnand a2af3bff15
Merge pull request #4098 from eatkins/filter
Exclude directories instead of including files
2018-04-23 08:15:11 +01:00
Dale Wijnand cd7eb95728
Merge pull request #4093 from laughedelic/unexpected-responses
WIP: Fix unexpected responses from the server
2018-04-23 08:02:30 +01:00
Dale Wijnand 187c50c78d
Merge pull request #4106 from dwijnand/overload-varargs-sorta
Switch inThisBuild (+friends) to use varargs SettingsDefinition
2018-04-20 16:11:29 +01:00
Dale Wijnand ccf938c786
Switch to varargs inThisBuild (+friends) 2018-04-19 22:34:52 +01:00
Dale Wijnand f459b218c4
Switch inThisBuild (+friends) to use varargs SettingsDefinition 2018-04-19 22:34:32 +01:00
Dale Wijnand dfff1ed928
Merge pull request #4032 from eed3si9n/wip/servertest
improve server testing
2018-04-18 07:12:53 +02:00
Eugene Yokota 1ec07c1867 Recover sbtOn 2018-04-17 23:26:29 +02:00
Ethan Atkins 2bb717dbf9 Exclude directories instead of including files
The existing filter caused SourceModificationWatch.watch to ignore
deleted files because !file.exists implies !file.isFile. The intention
of the filter was to exclude directories that had a name ending in
".scala".
2018-04-13 11:36:40 -07:00
Alexey Alekhin a1e3146c08
Don't use initialize request id for the internal collectAnalyses call 2018-04-12 19:47:32 +02:00
Dale Wijnand a8c1239e32
Merge pull request #4058 from retronym/topic/quietly-cancel
Avoid printing RejectedExectionExeption stack trace after cancellation
2018-04-11 12:00:03 +01:00
Dale Wijnand 2e2c3f6e89
Merge pull request #4087 from hvesalai/patch-2
Update to Jline 2.14.6
2018-04-11 11:55:56 +01:00
Eugene Yokota 190dc23f70 Fixes linter that detects missing .value
Fixes #4079

#3216 introduced a linter that checks against missing `.value`, but the tree only checked for `Ident`. This doesn't work because in reality the symbols of build.sbt are transformed to `$somehash.npmInstallTask` where `somehash` is the wrapper object we create. Similarly for the built-in keys, they are presented as `sbt.Keys.compile`.

With this change unused task will fail to load the build with the following message:

```
/sbt-4079/build.sbt:26: error: The key `compile` is not being invoked inside the task definition.

Problem: Keys missing `.value` are not initialized and their dependency is not registered.

Solution: Replace `compile` by `compile.value` or remove it if unused.

  compile
  ^
/sbt-4079/build.sbt:27: error: The key `npmInstallTask` is not being invoked inside the task definition.

Problem: Keys missing `.value` are not initialized and their dependency is not registered.

Solution: Replace `npmInstallTask` by `npmInstallTask.value` or remove it if unused.

  npmInstallTask
  ^
```
2018-04-11 01:31:38 -04:00
Heikki Vesalainen e5a37cad42
Update to Jline 2.14.6
This version of Jline fixes three things for Emacs users:
- ANSI colors are now enabled for Emacs.
- Terminal echo is now disabled for Emacs.
- History is enabled for all dump terminals.
2018-04-11 00:10:56 +03:00
Dale Wijnand 54a6262f7f
Merge pull request #4041 from dwijnand/Scoped.equals
Give Scoped a default equals/hashCode implementation
2018-04-10 06:10:55 +01:00
eugene yokota 7ae83cc755
Merge pull request #4085 from eed3si9n/wip/bumpzinc
Zinc 1.1.5
2018-04-09 13:37:50 -04:00
Eugene Yokota b9eb7764f3 Zinc 1.1.5 2018-04-09 12:37:42 -04:00
Dale Wijnand 4fc45e0155
Merge pull request #4056 from BennyHill/fix/3042
Introduce CompositeProject
2018-04-09 11:30:17 +01:00
Dale Wijnand 98e2b0b5d3
Merge pull request #4082 from eed3si9n/wip/repl
Re-fixing console and JLine
2018-04-09 11:23:58 +01:00
Dale Wijnand 6718803ee6
Merge pull request #4080 from naferx/add-lastGrep
Add lastGrep command
2018-04-09 07:19:17 +01:00
Eugene Yokota 8ed796fb25 Re-fixing console and JLine
Fixes #3482 take 2

I thought I tested #4054 using a local build, but when I ran 1.1.3, `console` did not display anything that I typed.
Switching to `usingTerminal` which calls `terminal.restore` similar to what I had in 1.1.1 fixes `console`.
2018-04-09 00:11:17 -04:00
eugene yokota 4d7149a7f3
Merge pull request #4078 from retronym/bump/houserules
Upgrade to latest sbt-houserules
2018-04-08 14:33:04 -04:00
Nafer Sanabria 3e201cee4d Add lastGrep command 2018-04-08 10:56:25 -05:00
Jason Zaugg 1abb0a3641 Upgrade to latest sbt-houserules 2018-04-08 14:31:48 +10:00
Alistair Johnson b0ad1a44c0 Remove projects parameter from CompositeProject.expand 2018-04-07 15:56:31 +02:00
eugene yokota 314ff46432
Merge pull request #4076 from eed3si9n/wip/bumplauncher
launcher 1.0.4
2018-04-06 19:35:27 -04:00