luke
/
sbt
mirror of https://github.com/sbt/sbt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
5,966 Commits 29 Branches 312 Tags 69 MiB
Commit Graph

5966 Commits

Author SHA1 Message Date
eugene yokota 5c32787574
Merge pull request #4071 from eed3si9n/wip/closewatch 
Use MacOSXWatchService instead of PollingWatchService
 2018-04-06 04:34:30 -04:00
Eugene Yokota 707bf08c4e Add new closewatch mode 2018-04-05 20:29:26 -04:00
eugene yokota b7d3959241
Merge pull request #4067 from eed3si9n/wip/reload-perf 
perf: optimize hash for build
 2018-04-05 10:37:41 -04:00
Eugene Yokota ad3692b2df Use NIO Files.getLastModifiedTime for hashing 2018-04-05 04:22:16 -04:00
Eugene Yokota 04d6a8b44c perf: optimize hash for build 
This hot path was discovered by retronym using FlameGraph.
This removes intermediate creation of Array.

`filesModifiedBytes` in particular was bad as it was going through all `*.class` files, each generating an Array. This replaces that with `fileModifiedHash` that accepts `MessageDigest`.

According to the flamegraph, evalCommon footprint reduced from 4.5% to 3.6%.
Using `time sbt reload reload reload exit`, the median reduced from 41.450s to 39.467s.
 2018-04-05 03:26:02 -04:00
Dale Wijnand 91483e7f06
Merge pull request #4063 from dwijnand/fix-migrate-url 
Fix migrate URL
 2018-04-04 16:31:57 +01:00
Dale Wijnand 8c1337455d
Fix migrate URL 
Fixes #4062
 2018-04-04 14:26:03 +01:00
Dale Wijnand 9b3694e443
Merge pull request #4054 from eed3si9n/wip/repl 
Fix console, JLine issue
 2018-04-03 16:44:42 +01:00
Dale Wijnand d444b6b8ae
Merge pull request #4002 from eed3si9n/wip/opt-delegation-test 
add tests around scope delegation
 2018-04-03 16:43:09 +01:00
Eugene Yokota 88f50ce35d Fix console, JLine issue 
Fixes #3482
 2018-03-30 23:09:01 -04:00
Ethan Atkins fff32db7ce Use MacOSXWatchService instead of PollingWatchService 
This watch service should be more responsive and significantly reduce
the disk overhead of the polling based service for large repos.
 2018-03-28 17:11:30 -07:00
eugene yokota fa56cf394b
Merge pull request #4046 from eed3si9n/wip/bumpsbt 
bump to 1.1.3-SNAPSHOT
 2018-03-28 09:11:19 -04:00
Eugene Yokota 1b77b35333 bump to 1.1.3-SNAPSHOT 2018-03-27 06:53:05 -04:00
Eugene Yokota f607b6c73f sbt 1.1.2 2018-03-27 06:52:32 -04:00
Dale Wijnand b0f9fe77b6
Merge pull request #4036 from eed3si9n/wip/fix-startup-log 
Fixes -error not suppressing startup logs
 2018-03-26 15:28:50 +01:00
eugene yokota cd40d1ac77
Merge pull request #4031 from eed3si9n/wip/bump 
bump modules
 2018-03-26 10:26:25 -04:00
Eugene Yokota 25ab94d96a Fixes -error not suppressing startup logs 
Fixes #3849

This brings back the 0.13 logic:

```scala
  def setGlobalLogLevel(s: State, level: Level.Value): State = {
    s.globalLogging.full match {
      case a: AbstractLogger => a.setLevel(level)
      case _                 => ()
    }
    s.put(BasicKeys.explicitGlobalLogLevels, true).put(Keys.logLevel.key, level)
  }
```
 2018-03-25 14:56:00 -04:00
Dale Wijnand 131c2a7a68
Merge pull request #4033 from eed3si9n/wip/new-mess 
Fixes new command leaving behind target directory
 2018-03-24 22:57:41 +00:00
Eugene Yokota b111b05d5f Fixes new command leaving target directory 
Fixes #2835

This fixes `new` command creating `target` directory by moving the `target` to a staging directory in the command itself.
 2018-03-24 13:45:35 -04:00
Eugene Yokota 9d2d81645b bump modules 2018-03-24 11:02:40 +09:00
Dale Wijnand a43c18e4f9
Merge pull request #4030 from eatkins/vector-1.1 
Vector 1.1
 2018-03-23 11:50:34 +00:00
Ethan Atkins 9b24e9f9eb Use ConcurrentLinkedDeque for EventHandler 
ArrayList::add is not thread safe. I ran into cases where async tests
using utests would fail even when all of the individual tests passed.
This was because multiple threads called back into the handle method of
the handler instance variable, which just delegated to eventList::add.
When this happened, one of the events would get added to the list as a
null reference, which would manifest as an NPE upstream on the master
process. After this change, my tests stopped failing.
 2018-03-21 10:50:30 -07:00
Ethan Atkins 8eb2d7389d Add test for async utest TestSuites 
Sometimes when utest runs async tests (i.e. tests that return a future)
the test suite will fail even when none of the individual tests do. This
is due to a data race in sbt. Most, but not all, of the time, this test
will induce that race.
 2018-03-21 10:41:41 -07:00
Dale Wijnand c6df309073
Merge pull request #4025 from tiqwab/fix-parsing-id 
Fix handling id in jsonrpc model
 2018-03-18 16:35:44 +00:00
Naohisa Murakami 9d01bdff68
Merge pull request #1 from eed3si9n/wip/fix-parsing-id 
Add test case for number id in JSON-RPC
 2018-03-18 07:38:25 +09:00
Eugene Yokota e5d2588927 Add test case for number id in JSON-RPC 2018-03-18 02:11:23 +09:00
tiqwab a5119a411c Fix handling id in jsonrpc model 
Fix #3861
 2018-03-17 22:41:47 +09:00
Dale Wijnand 6abf4c9e00
Merge pull request #4022 from tmiyamon/support-vscode-test-compile 
support test compile on saving in vscode
 2018-03-16 10:12:32 +00:00
tmiyamon 77ffbe896d support test compile on saving in vscode 2018-03-16 18:03:52 +09:00
eugene yokota 571417dc6f
Merge pull request #4019 from itohiro73/improve-contributing 
Improve instruction for locally built sbt in CONTRIBUTING.md
 2018-03-16 15:24:22 +09:00
Hiroshi Ito 04ab2d30e1 Improve instruction for locally built sbt in CONTRIBUTING.md 2018-03-16 15:07:17 +09:00
eugene yokota 4efce7e877
Merge pull request #3991 from dwijnand/ExecStatusEvent-exitCode 
Add an optional exitCode to ExecStatusEvent so clients can use it
 2018-03-16 00:27:17 +09:00
Dale Wijnand 98332c0891
Reply to sbt/exec w/ a Response/Error w/ error code 2018-03-14 13:56:29 +00:00
Dale Wijnand bde6365013
Add an optional exitCode to ExecStatusEvent so clients can use it 2018-03-14 11:56:51 +00:00
Dale Wijnand 7baf97d2a6
Introduce ErrorCodes.UnknownError 
Defined in the application defined errors range.
 2018-03-14 11:56:51 +00:00
Dale Wijnand 3530349e9a
Rename ErrorCodes' UnknownErrorCode to UnknownServerError 
Allows for a non-server-specific unknown error code to be defined.
 2018-03-14 11:56:50 +00:00
Dale Wijnand 8972287892
Cleanup ErrorCodes 2018-03-14 11:56:29 +00:00
Dale Wijnand dd4de14593
Upgrade to contraband 0.4.0 2018-03-12 15:39:07 +00:00
Eugene Yokota b82a1870a7 add tests around scope delegation 2018-03-10 17:24:39 -05:00
eugene yokota 3559de06aa
Merge pull request #3999 from eed3si9n/wip/cache-watch-service 
[bport] Cache watch service
 2018-03-09 17:42:11 -05:00
Ethan Atkins 5df1d8e23f Cache watch service 
I noticed that my custom WatchService was never cleaned up by sbt and
realized that after every build we were making a new WatchService. At
the same time, we were reusing the WatchState from the previous run,
which was using the original WatchService. This was particularly
problematic because it prevented us from registering any paths with the
new watch service. This may have prevented some of the file updates
from being seen by the watch service. Moreover, because we lost the
reference to the original WatchService, there was no way to clean it up,
which was a resource leak.

May be related to #3775, #3695
 2018-03-09 06:11:52 -05:00
Dale Wijnand ed5a8c118b
Upgrade to contraband 0.3.3 2018-03-08 12:49:38 +00:00
eugene yokota 27bbde810d
Merge pull request #3970 from retronym/ticket/3737 
Use Java's redirectInput rather than sys.process's connectInput
 2018-02-28 04:14:05 -05:00
eugene yokota 083dd8cad8
Merge pull request #3967 from dwijnand/buildinfo 
Upgrade to sbt-buildinfo 0.8.0
 2018-02-28 02:13:01 -05:00
Jason Zaugg b0f52510e0 Use Java's redirectInput rather than sys.process's connectInput 
Fixes #3737
 2018-02-26 11:30:30 +10:00
Dale Wijnand 27fe5a6957
Re-write toolboxClasspath to use sbt-buildinfo 2018-02-23 13:20:19 +00:00
Dale Wijnand 8182741480
Cleanup generateToolboxClasspath 2018-02-23 13:19:07 +00:00
Dale Wijnand edb828a8d7
Upgrade to sbt-buildinfo 0.8.0 2018-02-23 13:19:05 +00:00
Dale Wijnand c7cc52092e
Fix how fullClasspath is defined in TestBuildInfo 2018-02-23 13:17:51 +00:00
xuwei-k c1e0785a1f
delete buildinfo.BuildInfo from sbt main 
sbt-buildinfo plugin have `buildInfoScopedSettings(Compile)` in default.
I think it is unnecessary. or we should set "buildinfoPackage in Compile" and "buildinfoObject in Compile"

https://github.com/sbt/sbt-buildinfo/blob/v0.7.0/src/main/scala/sbtbuildinfo/BuildInfoPlugin.scala#L11
 2018-02-22 16:46:58 +00:00