Commit Graph

17940 Commits

Author SHA1 Message Date
Kamil Podsiadlo 6eb911ad15 refactor: simplify JVm environment requests
refactor: extract common logic to the `bspInputTask`
2022-04-12 20:09:35 +02:00
Kamil Podsiadlo ad4113caeb feat: implement BSP's JVM environment requests 2022-04-12 20:09:31 +02:00
Kamil Podsiadlo 85efc87879 feat: generate JVM environment requests 2022-04-12 20:09:26 +02:00
Adrien Piquerez bf7e255e74
Merge branch 'develop' into feat/bsp-env-request 2022-04-12 17:49:52 +02:00
Chris Kipp f90b09f1ee feat: update Problem to account for related information and code
This PR makes changes to the existing `xsbti.Problem` to account for an
optional diagnostic code that the compiler can return for a given
diagnostic and also related information.

Given a piece of code like:

```scala
try {}
```

You'll receive the following:

```
-- [E002] Syntax Warning: /Users/ckipp/Documents/scala-workspace/dotty-error-index/examples/002_EmptyCatchAndFinallyBlockID.scala:3:2
3 |  try {}
  |  ^^^^^^
  |  A try without catch or finally is equivalent to putting
  |  its body in a block; no exceptions are handled.
```

The `E002` here is the actual code. Right now there would be no
description.

Some diagnostics have multiple positions that they need to represent.
You can see an example of this
[here](lampepfl/dotty#14002) in Dotty with the
use of inlining. Instead of needing to rely on including all of that
information in the diagnostic message it can now be extracted out into
a `DiagnosticRelatedInformation`.

These changes reference the conversation in #6868
2022-04-12 11:13:19 +02:00
eugene yokota c8da751da7
Merge pull request #6872 from sbt/dependabot/github_actions/actions/setup-java-3
Bump actions/setup-java from 2 to 3
2022-04-11 15:28:28 -04:00
eugene yokota c00a2eacf2
Merge pull request #6870 from eatkins/watch-on-termination
Restore watchOnTermination callbacks
2022-04-11 13:43:23 -04:00
dependabot[bot] 97005df612
Bump actions/setup-java from 2 to 3
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2 to 3.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](https://github.com/actions/setup-java/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-11 04:02:44 +00:00
Ethan Atkins 379503a894 Restore watchOnTermination
At some point the watchOnTermination callback stopped working. I'm not
exactly sure how or why that happened but it is fairly straightforward
to restore. The one tricky thing was that the callback has the signature
(Watch.Action, _, _, _) => State, which requires propagating the action
to the failWatch command. The easiest way to do this was to add a
mutable field to the ContinuousState. This is rather ugly and reflects
some poor design choices but a more comprehensive refactor is out of
the scope of this fix.

This commit adds a scripted test that ensures that the callback is
invoked both in the successful and unsuccessful watch cases. In each
case the callback deletes a file and we ensure that the file is indeed
absent after the watch exits.
2022-04-09 15:49:10 -07:00
Ethan Atkins d3ee1d5942 Move on-termination test 2022-04-09 15:40:52 -07:00
Scala Steward a38d3954ca
Update coursier to 2.1.0-M5 (#384) 2022-04-08 14:01:41 +02:00
Scala Steward 0e3dd7efb9
Update scala-collection-compat to 2.7.0 (#386) 2022-04-08 14:01:35 +02:00
Scala Steward b95750b840
Update sbt-mima-plugin to 1.1.0 (#388) 2022-04-08 14:01:22 +02:00
Kamil Podsiadlo 77355134d0 tests: run&test environment requests 2022-04-06 09:09:51 +02:00
Kamil Podsiadlo 19b3ddb8e8 refactor: simplify JVm environment requests
refactor: extract common logic to the `bspInputTask`
2022-04-06 09:09:51 +02:00
Kamil Podsiadlo 5ea12485c6 feat: implement BSP's JVM environment requests 2022-04-06 09:09:51 +02:00
Kamil Podsiadlo 4f3ff52f6e feat: generate JVM environment requests 2022-04-06 09:09:51 +02:00
dependabot[bot] e0f309f4c6 Bump actions/cache from 2.1.7 to 3
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.7 to 3.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](https://github.com/actions/cache/compare/v2.1.7...v3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-01 16:00:38 +09:00
David Gregory dd497063e5
Add Remove instances for Set and Map 2022-03-30 19:03:14 +01:00
eugene yokota d065f38576
Merge pull request #6854 from eed3si9n/bport/6847
[1.7.x] Do not fire `build/publishDiagnostics` if there are (and were) no problems
2022-03-27 00:55:00 -04:00
eugene yokota 71f45ba404
Merge pull request #6853 from eed3si9n/bport/6849
[1.7.x] includePluginResolvers should work for coursier resolutions
2022-03-27 00:54:48 -04:00
Rikito Taniguchi f5e9ab8424 Add test to verify server doesn't send notifications 2022-03-27 00:12:30 -04:00
Rikito Taniguchi 620c55d6ac Re-publish warnings on BSP server startup
Imitate 8aaf828b03
2022-03-27 00:12:23 -04:00
Rikito Taniguchi 862d373f02 Don't fire publishDiagnostic if there's no problems both in current and previous compilation 2022-03-27 00:12:14 -04:00
eugene yokota 878250e78e
Merge pull request #6847 from tanishiking/donot-publish-bsp
[BSP]Do not fire `build/publishDiagnostics` if there are (and were) no problems
2022-03-27 00:10:32 -04:00
Brice Jaglin 491f70cd30 includePluginResolvers should work for coursier resolutions 2022-03-27 00:06:55 -04:00
eugene yokota c09a8b579f
Merge pull request #6849 from bjaglin/includePluginResolvers
includePluginResolvers should work for coursier resolutions
2022-03-27 00:03:20 -04:00
eugene yokota 2962b088a0
Merge pull request #6814 from prolativ/scala-release-flag
Add support for Scala 3 -scala-output-version flag
2022-03-26 23:36:16 -04:00
Michał Pałka 1e89d71311 Add support for scala-output-version flag in Scala 3 2022-03-24 15:35:57 +01:00
eugene yokota 204bedac9c
Merge pull request #6832 from sbt/dependabot/github_actions/actions/setup-python-3
Bump actions/setup-python from 2 to 3
2022-03-23 14:43:41 -04:00
Brice Jaglin fb479efdf9 includePluginResolvers should work for coursier resolutions 2022-03-23 12:25:35 +01:00
Rikito Taniguchi 893cfbba39 Add test to verify server doesn't send notifications 2022-03-21 22:14:44 +09:00
Rikito Taniguchi f118d2d73b Re-publish warnings on BSP server startup
Imitate 8aaf828b03
2022-03-21 22:14:42 +09:00
Rikito Taniguchi 80e87531d3 Don't fire publishDiagnostic if there's no problems both in current and previous compilation 2022-03-21 22:14:04 +09:00
Amina Adewusi 020385d917 Attempts to fix sbt#6810 - deadlock issue 2022-03-18 17:23:30 +00:00
eugene yokota 2338bea9db
Merge pull request #6839 from sbt/1.7.x
Porting 1.7.x to develop
2022-03-18 12:17:26 -04:00
Adrien Piquerez f0552e4bc3
Merge pull request #6830 from kpodsiad/feat/scala-test-classes-framework
feat: add optional framework field to the bsp
2022-03-16 08:56:10 +01:00
Kamil Podsiadlo ce978a19ed tests: add test case for framework field in scala test classes request 2022-03-10 19:56:49 +01:00
eugene yokota 7c197ea8ee
Merge branch 'develop' into dependabot/github_actions/actions/setup-python-3 2022-03-08 18:54:40 -07:00
eugene yokota fedf6af60d
Merge pull request #6833 from sbt/dependabot/github_actions/actions/checkout-3
Bump actions/checkout from 2 to 3
2022-03-08 18:54:22 -07:00
Adrien Piquerez 1396e1605d Try fix CI: Build and test (6) 2022-03-08 18:19:20 +01:00
dependabot[bot] 144398ec73
Bump actions/checkout from 2 to 3
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-07 04:03:17 +00:00
dependabot[bot] 466410464c
Bump actions/setup-python from 2 to 3
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 3.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-07 04:03:15 +00:00
Kamil Podsiadlo 23b50688ba feat: add optional framework field to the bsp 2022-03-04 10:53:25 +01:00
eugene yokota ba5f7527fe
Merge pull request #6824 from gontard/remote_cache_not_found_log
Improve log for not found remote cache artifact
2022-02-26 20:43:00 -05:00
gontard d25dfd06ab Improve log for not found remote cache artifact
Before
remote cache not found for 0.0.0-7c40144bd1c774e6

After
remote cache artifact not found for org.gontard:sbt-test:0.0.0-7c40144bd1c774e6 Some(cached-compile)
2022-02-25 16:14:53 +01:00
eugene yokota 18882088cd
Merge pull request #6820 from tsawada/friendly-curl
launcher: debian package to depend on curl | wget
2022-02-21 23:39:41 -05:00
Takeo Sawada a0e5b553ef launcher: debian package to depend on curl | wget
also give informative error message when neither is available
2022-02-21 17:38:18 +09:00
eugene yokota c7f2c046b6
Merge pull request #6816 from Nirvikalpa108/fix-6802
Fixes parsing command args that include quotes but don't start with them
2022-02-04 14:42:22 -05:00
Amina Adewusi ca8fd354bd Fixes parsing command args quote problem
Fixes #6802.
2022-02-04 17:52:39 +00:00