Merge pull request #35 from sbt/feature/windows-sbt-config

Feature/windows sbt config
2012-10-26 06:07:54 -07:00 · 2012-10-26 06:07:54 -07:00 · f5a22c9576
parent a934680c8d db3413e9c1
commit f5a22c9576
4 changed files with 75 additions and 11 deletions
--- a/.gitattributes
+++ b/.gitattributes
@ -0,0 +1 @@
+src/windows/sbtconfig.txt        eol=crlf
--- a/project/packaging.scala
+++ b/project/packaging.scala
@ -143,7 +143,10 @@ object Packaging {
    
    // WINDOWS SPECIFIC
    name in Windows := "sbt",
-    lightOptions ++= Seq("-ext", "WixUIExtension", "-cultures:en-us"),
+    candleOptions ++= Seq("-ext", "WixUtilExtension"),
+    lightOptions ++= Seq("-ext", "WixUIExtension",
+                         "-ext", "WixUtilExtension",
+                         "-cultures:en-us"),
    wixConfig <<= (sbtVersion, sourceDirectory in Windows) map makeWindowsXml,
    //wixFile <<= sourceDirectory in Windows map (_ / "sbt.xml"),
    mappings in packageMsi in Windows <+= sbtLaunchJar map { f => f -> "sbt-launch.jar" },
@ -151,6 +154,7 @@ object Packaging {
    mappings in packageMsi in Windows <++= sourceDirectory in Windows map { d => Seq(
      (d / "sbt.bat") -> "sbt.bat",
      (d / "sbt") -> "sbt",
+      (d / "sbtconfig.txt") -> "sbtconfig.txt",
      (d / "jansi-license.txt") -> "jansi-license.txt"
    )},
    mappings in packageMsi in Windows <+= (compile in Compile, classDirectory in Compile) map { (c, d) =>
@ -196,7 +200,8 @@ object Packaging {
        case Array(major) => Seq(major,"0","0","1") mkString "."
      }
      (
-<Wix xmlns='http://schemas.microsoft.com/wix/2006/wi' xmlns:util='http://schemas.microsoft.com/wix/UtilExtension'>
+<Wix xmlns='http://schemas.microsoft.com/wix/2006/wi' 
+     xmlns:util='http://schemas.microsoft.com/wix/UtilExtension'>
  <Product Id='ce07be71-510d-414a-92d4-dff47631848a' 
            Name='Simple Build Tool' 
            Language='1033'
@ -211,9 +216,18 @@ object Packaging {
                Compressed='yes' />
 
      <Media Id='1' Cabinet='sbt.cab' EmbedCab='yes' />
+      
+      <Property Id='NOTEPADEXE'>
+        <DirectorySearch Id='NotePadContainer' Path='[SystemFolder]' Depth='0'>
+          <FileSearch Id='NotepadFile' Name='notepad.exe'/>
+        </DirectorySearch>
+      </Property>
 
      <Directory Id='TARGETDIR' Name='SourceDir'>
-         <Directory Id='ProgramFilesFolder' Name='PFiles'>
+        <Directory Id="ProgramMenuFolder">
+          <Directory Id="ApplicationProgramsFolder" Name="sbt"/>
+        </Directory>
+        <Directory Id='ProgramFilesFolder' Name='PFiles'>
            <Directory Id='INSTALLDIR' Name='sbt'>
               <Directory Id='classes_dir' Name='classes'>
                  <Component Id='JansiLaunch' Guid='*'>
@ -222,12 +236,19 @@ object Packaging {
               </Directory>
               <Component Id='SbtLauncherScript' Guid='DE0A5B50-0792-40A9-AEE0-AB97E9F845F5'>
                  <File Id='sbt_bat' Name='sbt.bat' DiskId='1' Source='sbt.bat'>
-                     <!-- <util:PermissionEx User="Users" Domain="[LOCAL_MACHINE_NAME]" GenericRead="yes" Read="yes" GenericExecute="yes" ChangePermission="yes"/> -->
+                     <util:PermissionEx User="Administrators" GenericAll="yes" />
+                     <util:PermissionEx User="Users" GenericAll="yes" />
                  </File>
                  <File Id='sbt_sh' Name='sbt' DiskId='1' Source='sbt'>
                     <!-- <util:PermissionEx User="Users" Domain="[LOCAL_MACHINE_NAME]" GenericRead="yes" Read="yes" GenericExecute="yes" ChangePermission="yes"/> -->
                  </File>
               </Component>
+               <Component Id='SbtConfigFile' Guid='*'>
+                 <File Id='sbtconfig_txt' Name='sbtconfig.txt' DiskId='1' Source='sbtconfig.txt'>
+                   <util:PermissionEx User="Administrators" GenericAll="yes" />
+                   <util:PermissionEx User="Users" GenericAll="yes" />
+                 </File>
+               </Component>
               <Component Id='JansiJar' Guid='3370A26B-E8AB-4143-B837-CE9A8573BF60'>
                  <File Id='jansi_jar' Name='jansi.jar' DiskId='1' Source='jansi.jar' />
                  <File Id='jansi_license' Name='jansi-license.txt' DiskId='1' Source='jansi-license.txt' />
@ -243,7 +264,19 @@ object Packaging {
             </Directory>
         </Directory>
      </Directory>
- 
+           <!-- Step 2: Add the shortcut to your installer package -->
+        <DirectoryRef Id="ApplicationProgramsFolder">
+            <Component Id="ConfigShortcut" Guid="3370A26B-E8AB-4143-B837-CE9A8573BF61">
+                <Shortcut Id="ConfigStartMenuShortcut"
+                          Name="sbt configuration"
+                          Description="Modify sbt configuration settings"
+                          Target="[INSTALLDIR]sbtconfig.txt"
+                          WorkingDirectory="INSTALLDIR"/>
+                <RemoveFolder Id="ApplicationProgramsFolder" On="uninstall"/>
+                <RegistryValue Root="HKCU" Key="Software\Typesafe\sbt" Name="installed" Type="integer" Value="1" KeyPath="yes"/>
+             </Component>
+        </DirectoryRef>
+        
      <Feature Id='Complete' Title='Simple Build Tool' Description='The windows installation of Simple Build Tool.'
         Display='expand' Level='1' ConfigurableDirectory='INSTALLDIR'>
        <Feature Id='SbtLauncher' Title='Sbt Launcher Script' Description='The application which downloads and launches SBT.' Level='1' Absent='disallow'>
@ -251,10 +284,14 @@ object Packaging {
          <ComponentRef Id='SbtLauncherJar' />
          <ComponentRef Id='JansiLaunch' />
          <ComponentRef Id='JansiJar' />
+          <ComponentRef Id='SbtConfigFile' />
        </Feature>
-        <Feature Id='SbtLauncherPathF' Title='Add SBT to windows system PATH' Description='This will append SBT to your windows system path.' Level='1'>
+        <Feature Id='SbtLauncherPathF' Title='Add SBT to windows system PATH' Description='This will append SBT to your windows system path (Requires Restart).' Level='1'>
          <ComponentRef Id='SbtLauncherPath'/>
        </Feature>
+        <Feature Id='SbtLauncherConfigF' Title='Add Menu Shortcuts' Description='This will add menu shortcuts for sbt configuration.' Level='1'>
+          <ComponentRef Id='ConfigShortcut'/>
+        </Feature>
      </Feature>
      <!--<Property Id="JAVAVERSION">
        <RegistrySearch Id="JavaVersion"
--- a/src/windows/sbt.bat
+++ b/src/windows/sbt.bat
@ -3,14 +3,26 @@
@REM Envioronment:
@REM JAVA_HOME - location of a JDK home dir (mandatory)
@REM SBT_OPTS  - JVM options (optional)
+@REM Configuration:
+@REM sbtconfig.txt found in the SBT_HOME.

-
-@setlocal
+@REM   ZOMG! We need delayed expansion to build up CFG_OPTS later 
+@setlocal enabledelayedexpansion

@echo off
 set SBT_HOME=%~dp0
 set ERROR_CODE=0

+rem FIRST we load the config file of extra options.
+set FN=%SBT_HOME%sbtconfig.txt
+set CFG_OPTS=
+FOR /F "tokens=* eol=# usebackq delims=" %%i IN ("%FN%") DO (
+  set DO_NOT_REUSE_ME=%%i
+  rem ZOMG (Part #2) WE use !! here to delay the expansion of
+  rem CFG_OPTS, otherwise it remains "" for this loop.
+  set CFG_OPTS=!CFG_OPTS! !DO_NOT_REUSE_ME!
+)
+
 rem We use the value of the JAVACMD environment variable if defined
 set _JAVACMD=%JAVACMD%

@ -22,9 +34,9 @@ if "%_JAVACMD%"=="" (

 if "%_JAVACMD%"=="" set _JAVACMD=java

-rem We use the value of the JAVA_OPTS environment variable if defined
+rem We use the value of the JAVA_OPTS environment variable if defined, rather than the config.
 set _JAVA_OPTS=%JAVA_OPTS%
-if "%_JAVA_OPTS%"=="" set _JAVA_OPTS=-Xmx512M -XX:MaxPermSize=256m -XX:ReservedCodeCacheSize=128m -Dsbt.log.format=true
+if "%_JAVA_OPTS%"=="" set _JAVA_OPTS=%CFG_OPTS%

 :run

@ -39,4 +51,4 @@ set ERROR_CODE=1

@endlocal

-exit /B %ERROR_CODE%
+exit /B %ERROR_CODE%
--- a/src/windows/sbtconfig.txt
+++ b/src/windows/sbtconfig.txt
@ -0,0 +1,14 @@
+# Set the java args to high
+
+-Xmx512M
+
+-XX:MaxPermSize=256m
+
+-XX:ReservedCodeCacheSize=128m
+
+
+
+# Set the extra SBT options
+
+-Dsbt.log.format=true
+