luke
/
sbt
mirror of https://github.com/sbt/sbt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update mimaPreviousArtifacts and mimaBinaryIssueFilters

This commit is contained in:
xuwei-k 2026-01-12 09:48:24 +09:00 committed by kenji yoshida
parent d3f7f6bf90
commit e5d05ca584
2 changed files with 5 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
build.sbt
View File

@ -117,7 +117,7 @@ def testedBaseSettings: Seq[Setting[?]] =
val sbt20Plus = val sbt20Plus =
Seq( Seq(
"2.0.0-RC7", "2.0.0-RC8",
) )
val mimaSettings = mimaSettingsSince(sbt20Plus) val mimaSettings = mimaSettingsSince(sbt20Plus)
def mimaSettingsSince(versions: Seq[String]): Seq[Def.Setting[?]] = Def settings ( def mimaSettingsSince(versions: Seq[String]): Seq[Def.Setting[?]] = Def settings (
@ -293,7 +293,6 @@ lazy val utilPosition = (project in file("internal") / "util-position")
libraryDependencies ++= Seq(hedgehog % Test), libraryDependencies ++= Seq(hedgehog % Test),
mimaSettings, mimaSettings,
mimaBinaryIssueFilters ++= Seq( mimaBinaryIssueFilters ++= Seq(
exclude[ReversedMissingMethodProblem]("sbt.internal.util.FilePosition.sourceCode"),
), ),
) )
@ -437,8 +436,6 @@ lazy val workerProj = (project in file("worker"))
Test / fork := true, Test / fork := true,
mimaSettings, mimaSettings,
mimaBinaryIssueFilters ++= Vector( mimaBinaryIssueFilters ++= Vector(
exclude[MissingClassProblem]("com.google.gson.typeadapters.RuntimeTypeAdapterFactory"),
exclude[IncompatibleResultTypeProblem]("sbt.internal.worker1.WorkerMain.mkGson"),
exclude[DirectMissingMethodProblem]("sbt.internal.worker1.TestInfo.this"), exclude[DirectMissingMethodProblem]("sbt.internal.worker1.TestInfo.this"),
), ),
) )
@ -547,8 +544,6 @@ lazy val actionsProj = (project in file("main-actions"))
Test / classLoaderLayeringStrategy := ClassLoaderLayeringStrategy.Flat, Test / classLoaderLayeringStrategy := ClassLoaderLayeringStrategy.Flat,
mimaSettings, mimaSettings,
mimaBinaryIssueFilters ++= Vector( mimaBinaryIssueFilters ++= Vector(
exclude[DirectMissingMethodProblem]("sbt.internal.WorkerExchange.*"),
exclude[DirectMissingMethodProblem]("sbt.internal.WorkerProxy.*"),
), ),
) )
.dependsOn(lmCore) .dependsOn(lmCore)
@ -716,7 +711,6 @@ lazy val mainProj = (project in file("main"))
Compile / doc / sources := Nil, Compile / doc / sources := Nil,
mimaSettings, mimaSettings,
mimaBinaryIssueFilters ++= Vector( mimaBinaryIssueFilters ++= Vector(
exclude[ReversedMissingMethodProblem]("sbt.ProjectMatrix.*"),
exclude[DirectMissingMethodProblem]("sbt.internal.ConsoleProject.*"), exclude[DirectMissingMethodProblem]("sbt.internal.ConsoleProject.*"),
), ),
) )

45
project/Mima.scala
View File

@ -30,50 +30,13 @@ object Mima {
) )
lazy val lmCoursierFilters = { lazy val lmCoursierFilters = {
mimaBinaryIssueFilters ++= { mimaBinaryIssueFilters ++= Seq(
import com.typesafe.tools.mima.core.* )
Seq(
// spurious errors on CI
ProblemFilters.exclude[IncompatibleSignatureProblem]("*"),
// Methods that shouldn't have been there
ProblemFilters.exclude[DirectMissingMethodProblem](
"lmcoursier.credentials.FileCredentials.get"
),
ProblemFilters.exclude[DirectMissingMethodProblem](
"lmcoursier.credentials.DirectCredentials.matches"
),
ProblemFilters.exclude[DirectMissingMethodProblem](
"lmcoursier.credentials.DirectCredentials.get"
),
ProblemFilters.exclude[DirectMissingMethodProblem](
"lmcoursier.credentials.DirectCredentials.autoMatches"
),
ProblemFilters.exclude[DirectMissingMethodProblem](
"lmcoursier.credentials.Credentials.get"
),
// Removed unused method, shouldn't have been there in the first place
ProblemFilters.exclude[DirectMissingMethodProblem](
"lmcoursier.credentials.DirectCredentials.authentication"
),
// ignore shaded and internal stuff related errors
(pb: Problem) => pb.matchName.forall(!_.startsWith("lmcoursier.internal."))
)
}
} }
lazy val lmCoursierShadedFilters = { lazy val lmCoursierShadedFilters = {
mimaBinaryIssueFilters ++= { mimaBinaryIssueFilters ++= Seq(
import com.typesafe.tools.mima.core.* )
Seq(
// spurious errors on CI
ProblemFilters.exclude[IncompatibleSignatureProblem]("*"),
// Should have been put under lmcoursier.internal?
(pb: Problem) => pb.matchName.forall(!_.startsWith("lmcoursier.definitions.ToCoursier.")),
(pb: Problem) => pb.matchName.forall(!_.startsWith("lmcoursier.definitions.FromCoursier."))
)
}
} }
} }