fix: Set contrabandScala3enum to false

This commit is contained in:
Eugene Yokota 2025-09-28 20:07:16 -04:00
parent d44b2c8720
commit d10f6ee54e
3 changed files with 34 additions and 91 deletions

View File

@ -141,6 +141,14 @@ def mimaSettingsSince(versions: Seq[String]): Seq[Def.Setting[?]] = Def settings
), ),
) )
val contrabandSettings: Seq[Def.Setting[?]] = Seq(
Compile / generateContrabands / sourceManaged := baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / managedSourceDirectories +=
baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / contrabandScala3enum := false,
Compile / generateContrabands / contrabandFormatsForType := DatatypeConfig.getFormats,
)
val scriptedSbtMimaSettings = Def.settings(mimaPreviousArtifacts := Set()) val scriptedSbtMimaSettings = Def.settings(mimaPreviousArtifacts := Set())
lazy val sbtRoot: Project = (project in file(".")) lazy val sbtRoot: Project = (project in file("."))
@ -315,10 +323,7 @@ lazy val utilLogging = project
sjsonNewScalaJson.value, sjsonNewScalaJson.value,
), ),
testDependencies, testDependencies,
Compile / generateContrabands / contrabandCodecsDependencies := List(sjsonNewCore.value), contrabandSettings,
Compile / generateContrabands / sourceManaged := baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / managedSourceDirectories +=
baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / contrabandFormatsForType := { tpe => Compile / generateContrabands / contrabandFormatsForType := { tpe =>
val old = (Compile / generateContrabands / contrabandFormatsForType).value val old = (Compile / generateContrabands / contrabandFormatsForType).value
val name = tpe.removeTypeParameters.name val name = tpe.removeTypeParameters.name
@ -358,10 +363,7 @@ lazy val utilCache = project
sjsonNewScalaJson.value, sjsonNewScalaJson.value,
sjsonNewMurmurhash.value sjsonNewMurmurhash.value
), ),
Compile / managedSourceDirectories += contrabandSettings,
baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / sourceManaged := baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / contrabandFormatsForType := ContrabandConfig.getFormats,
mimaSettings, mimaSettings,
mimaBinaryIssueFilters ++= Seq( mimaBinaryIssueFilters ++= Seq(
), ),
@ -411,10 +413,7 @@ lazy val testingProj = (project in file("testing"))
sjsonNewCore.value, sjsonNewCore.value,
), ),
conflictWarning := ConflictWarning.disable, conflictWarning := ConflictWarning.disable,
Compile / managedSourceDirectories += contrabandSettings,
baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / sourceManaged := baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / contrabandFormatsForType := ContrabandConfig.getFormats,
mimaSettings, mimaSettings,
mimaBinaryIssueFilters ++= Vector( mimaBinaryIssueFilters ++= Vector(
), ),
@ -476,9 +475,7 @@ lazy val runProj = (project in file("run"))
.settings( .settings(
testedBaseSettings, testedBaseSettings,
name := "Run", name := "Run",
Compile / managedSourceDirectories += contrabandSettings,
baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / sourceManaged := baseDirectory.value / "src" / "main" / "contraband-scala",
mimaSettings, mimaSettings,
mimaBinaryIssueFilters ++= Seq( mimaBinaryIssueFilters ++= Seq(
) )
@ -537,10 +534,7 @@ lazy val actionsProj = (project in file("main-actions"))
name := "Actions", name := "Actions",
libraryDependencies += sjsonNewScalaJson.value, libraryDependencies += sjsonNewScalaJson.value,
libraryDependencies ++= Seq(gigahorseApacheHttp, jline3Terminal), libraryDependencies ++= Seq(gigahorseApacheHttp, jline3Terminal),
Compile / managedSourceDirectories += contrabandSettings,
baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / sourceManaged := baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / contrabandFormatsForType := ContrabandConfig.getFormats,
// Test / fork := true, // Test / fork := true,
Test / classLoaderLayeringStrategy := ClassLoaderLayeringStrategy.Flat, Test / classLoaderLayeringStrategy := ClassLoaderLayeringStrategy.Flat,
mimaSettings, mimaSettings,
@ -564,10 +558,7 @@ lazy val protocolProj = (project in file("protocol"))
name := "Protocol", name := "Protocol",
libraryDependencies ++= Seq(sjsonNewScalaJson.value, sjsonNewCore.value, ipcSocket), libraryDependencies ++= Seq(sjsonNewScalaJson.value, sjsonNewCore.value, ipcSocket),
Compile / scalacOptions += "-source:3.7", Compile / scalacOptions += "-source:3.7",
Compile / managedSourceDirectories += contrabandSettings,
baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / sourceManaged := baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / contrabandFormatsForType := ContrabandConfig.getFormats,
mimaSettings, mimaSettings,
mimaBinaryIssueFilters ++= Seq( mimaBinaryIssueFilters ++= Seq(
) )
@ -586,10 +577,7 @@ lazy val commandProj = (project in file("main-command"))
sjsonNewScalaJson.value, sjsonNewScalaJson.value,
templateResolverApi templateResolverApi
), ),
Compile / managedSourceDirectories += contrabandSettings,
baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / sourceManaged := baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / contrabandFormatsForType := ContrabandConfig.getFormats,
mimaSettings, mimaSettings,
mimaBinaryIssueFilters ++= Vector( mimaBinaryIssueFilters ++= Vector(
), ),
@ -713,9 +701,7 @@ lazy val mainProj = (project in file("main"))
case v if v.startsWith("2.12.") => List() case v if v.startsWith("2.12.") => List()
case _ => List(scalaPar) case _ => List(scalaPar)
}), }),
Compile / managedSourceDirectories += contrabandSettings,
baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / sourceManaged := baseDirectory.value / "src" / "main" / "contraband-scala",
Test / testOptions += Tests Test / testOptions += Tests
.Argument(TestFrameworks.ScalaCheck, "-minSuccessfulTests", "1000"), .Argument(TestFrameworks.ScalaCheck, "-minSuccessfulTests", "1000"),
SettingKey[Boolean]("usePipelining") := false, SettingKey[Boolean]("usePipelining") := false,
@ -1142,10 +1128,7 @@ lazy val lmCore = (project in file("lm-core"))
case v if v.startsWith("2.12.") => List("-Ywarn-unused:-locals,-explicits,-privates") case v if v.startsWith("2.12.") => List("-Ywarn-unused:-locals,-explicits,-privates")
case _ => List() case _ => List()
}), }),
Compile / managedSourceDirectories += contrabandSettings,
baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / sourceManaged := baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / contrabandFormatsForType := DatatypeConfig.getFormats,
// WORKAROUND sbt/sbt#2205 include managed sources in packageSrc // WORKAROUND sbt/sbt#2205 include managed sources in packageSrc
Compile / packageSrc / mappings ++= { Compile / packageSrc / mappings ++= {
val srcs = (Compile / managedSources).value val srcs = (Compile / managedSources).value
@ -1177,10 +1160,7 @@ lazy val lmIvy = (project in file("lm-ivy"))
scalacheck % Test, scalacheck % Test,
scalaVerify % Test, scalaVerify % Test,
), ),
Compile / managedSourceDirectories += contrabandSettings,
baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / sourceManaged := baseDirectory.value / "src" / "main" / "contraband-scala",
Compile / generateContrabands / contrabandFormatsForType := DatatypeConfig.getFormats,
Test / classLoaderLayeringStrategy := ClassLoaderLayeringStrategy.Flat, Test / classLoaderLayeringStrategy := ClassLoaderLayeringStrategy.Flat,
mimaSettings, mimaSettings,
) )

View File

@ -1,53 +0,0 @@
import sbt.contraband.ast.*
import sbt.contraband.CodecCodeGen
object ContrabandConfig {
/** Extract the only type parameter from a TpeRef */
def oneArg(tpe: Type): Type = {
val pat = s"""${tpe.removeTypeParameters.name}[<\\[](.+?)[>\\]]""".r
val pat(arg0) = tpe.name
NamedType(arg0 split '.' toList)
}
/** Extract the two type parameters from a TpeRef */
def twoArgs(tpe: Type): List[Type] = {
val pat = s"""${tpe.removeTypeParameters.name}[<\\[](.+?), (.+?)[>\\]]""".r
val pat(arg0, arg1) = tpe.name
NamedType(arg0 split '.' toList) :: NamedType(arg1 split '.' toList) :: Nil
}
/** Codecs that were manually written. */
val myCodecs: PartialFunction[String, Type => List[String]] = {
// TODO: These are handled by BasicJsonProtocol, and sbt-contraband should handle them by default, imo
case "Option" | "Set" | "scala.Vector" => { tpe =>
getFormats(oneArg(tpe))
}
case "Map" | "Tuple2" | "scala.Tuple2" => { tpe =>
twoArgs(tpe).flatMap(getFormats)
}
case "Int" | "Long" => { _ =>
Nil
}
case "sbt.testing.Status" => { _ =>
"sbt.internal.testing.StatusFormats" :: Nil
}
case "scalajson.ast.unsafe.JValue" | "sjsonnew.shaded.scalajson.ast.unsafe.JValue" => { _ =>
"sbt.internal.util.codec.JValueFormats" :: Nil
}
case "xsbti.HashedVirtualFileRef" => { _ =>
"sbt.internal.util.codec.HashedVirtualFileRefFormats" :: Nil
}
case "java.nio.ByteBuffer" => { _ =>
"sbt.internal.util.codec.ByteBufferFormats" :: Nil
}
}
/** Returns the list of formats required to encode the given `TpeRef`. */
val getFormats: Type => List[String] =
CodecCodeGen.extensibleFormatsForType {
case tpe: Type if myCodecs isDefinedAt tpe.removeTypeParameters.name =>
myCodecs(tpe.removeTypeParameters.name)(tpe)
case other => CodecCodeGen.formatsForType(other)
}
}

View File

@ -62,6 +62,22 @@ object DatatypeConfig {
"sbt.librarymanagement.ConfigRefFormats" :: Nil "sbt.librarymanagement.ConfigRefFormats" :: Nil
} }
case "sbt.testing.Status" => { _ =>
"sbt.internal.testing.StatusFormats" :: Nil
}
case "scalajson.ast.unsafe.JValue" | "sjsonnew.shaded.scalajson.ast.unsafe.JValue" => { _ =>
"sbt.internal.util.codec.JValueFormats" :: Nil
}
case "xsbti.HashedVirtualFileRef" => { _ =>
"sbt.internal.util.codec.HashedVirtualFileRefFormats" :: Nil
}
case "java.nio.ByteBuffer" => { _ =>
"sbt.internal.util.codec.ByteBufferFormats" :: Nil
}
// TODO: These are handled by BasicJsonProtocol, and sbt-datatype should handle them by default, imo // TODO: These are handled by BasicJsonProtocol, and sbt-datatype should handle them by default, imo
case "Option" | "Set" | "scala.Vector" => { tpe => case "Option" | "Set" | "scala.Vector" => { tpe =>
getFormats(oneArg(tpe)) getFormats(oneArg(tpe))