luke
/
sbt
mirror of https://github.com/sbt/sbt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary infra for .value DSL check

This commit is contained in:
jvican 2017-05-28 18:36:14 +02:00
parent 6a31251a01
commit c85fb95851
No known key found for this signature in database
GPG Key ID: 42DAFA0F112E8050
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
main-settings/src/main/scala/sbt/std/TaskLinterDSL.scala
View File

@ -20,7 +20,6 @@ abstract class BaseTaskLinterDSL extends LinterDSL {
private val settingKeyType = typeOf[sbt.SettingKey[_]]
private val inputKeyType = typeOf[sbt.InputKey[_]]
private val uncheckedWrappers = MutableSet.empty[Tree]
private val identsWithValue = MutableSet.empty[Ident]
var insideIf: Boolean = false
var insideAnon: Boolean = false
var disableNoValueReport: Boolean = false
@ -61,11 +60,6 @@ abstract class BaseTaskLinterDSL extends LinterDSL {
override def traverse(tree: ctx.universe.Tree): Unit = {
tree match {
case ap @ Apply(TypeApply(Select(_, nme), tpe :: Nil), qual :: Nil) =>
// Keep track of wrapped idents to detect missing `.value`
qual match {
case i: Ident => identsWithValue.add(i)
case _ => ()
}
val shouldIgnore = uncheckedWrappers.contains(ap)
val wrapperName = nme.decodedName.toString
if (!shouldIgnore && isTask(wrapperName, tpe.tpe, qual)) {