mirror of https://github.com/sbt/sbt.git
review comments
This commit is contained in:
parent
a6f83dda97
commit
c73f513016
|
|
@ -84,8 +84,7 @@ final class DiagnosticsReporter(reporter: Reporter) extends DiagnosticListener[J
|
||||||
case _ => None
|
case _ => None
|
||||||
}
|
}
|
||||||
} catch {
|
} catch {
|
||||||
case ignored: NoSuchMethodException => None
|
case ignored: ReflectiveOperationException => None
|
||||||
case ignored: NoSuchFieldException => None
|
|
||||||
}
|
}
|
||||||
|
|
||||||
def getExpression: String =
|
def getExpression: String =
|
||||||
|
|
|
||||||
|
|
@ -114,7 +114,7 @@ object JavaCompilerSpec extends Specification {
|
||||||
case Some(content) => content.equalsIgnoreCase(p.position.lineContent())
|
case Some(content) => content.equalsIgnoreCase(p.position.lineContent())
|
||||||
case _ => true
|
case _ => true
|
||||||
}
|
}
|
||||||
def lineNumberCheck = p.position.line.isDefined && (p.position.line.get == lineno)
|
def lineNumberCheck = p.position.line.exists(_ == lineno)
|
||||||
lineNumberCheck && lineContentCheck
|
lineNumberCheck && lineContentCheck
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -1,5 +1,6 @@
|
||||||
|
|
||||||
[@fkorotkov]: http://github.com/fkorotkov
|
[@fkorotkov]: http://github.com/fkorotkov
|
||||||
|
[#2108]: https://github.com/sbt/sbt/pull/2108
|
||||||
|
|
||||||
### Fixes with compatibility implications
|
### Fixes with compatibility implications
|
||||||
|
|
||||||
Loading…
Reference in New Issue