luke
/
sbt
mirror of https://github.com/sbt/sbt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[2.x] fix: Race condition in WorkerExchangeTest.propBye (#8606)

This commit is contained in:
calm 2026-01-21 21:49:41 -08:00 committed by GitHub
parent 527f109671
commit c099be5f18
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
main-actions/src/test/scala/sbt/internal/WorkerExchangeTest.scala
View File

@ -41,6 +41,7 @@ object WorkerExchangeTest extends Properties:
yield withListener: l =>
w.println(s"""{"jsonrpc": "2.0", "method": "bye", "params": {}, "id": $i}""")
val exitCode = w.blockForExitCode()
l.awaitResponse()
Result
.assert(exitCode == 0)
.and(Result.assert(l.sb.toString() == s"""{ "jsonrpc": "2.0", "result": 0, "id": $i }"""))
@ -54,7 +55,12 @@ object WorkerExchangeTest extends Properties:
finally WorkerExchange.unregisterListener(l)
class ConcreteListener extends WorkerResponseListener:
import java.util.concurrent.{ CountDownLatch, TimeUnit }
val sb = StringBuilder()
private val latch = CountDownLatch(1)
def notifyExit(p: Process): Unit = ()
def apply(line: String): Unit = sb.append(line)
def apply(line: String): Unit =
sb.append(line)
latch.countDown()
def awaitResponse(): Unit = latch.await(30, TimeUnit.SECONDS)
end WorkerExchangeTest