Merge pull request #2035 from dwijnand/project-level-exclusions-in-pom

Add project-level exclusions in the POM.
This commit is contained in:
Josh Suereth 2015-05-28 09:29:04 -04:00
commit b846136c03
1 changed files with 30 additions and 10 deletions

View File

@ -104,7 +104,7 @@ class MakePom(val log: Logger) {
{ {
val deps = depsInConfs(module, configurations) val deps = depsInConfs(module, configurations)
makeProperties(module, deps) ++ makeProperties(module, deps) ++
makeDependencies(deps, includeTypes) makeDependencies(deps, includeTypes, module.getAllExcludeRules)
} }
{ makeRepositories(ivy.getSettings, allRepositories, filterRepositories) } { makeRepositories(ivy.getSettings, allRepositories, filterRepositories) }
</project>) </project>)
@ -220,37 +220,49 @@ class MakePom(val log: Logger) {
} }
val IgnoreTypes: Set[String] = Set(Artifact.SourceType, Artifact.DocType, Artifact.PomType) val IgnoreTypes: Set[String] = Set(Artifact.SourceType, Artifact.DocType, Artifact.PomType)
@deprecated("Use `makeDependencies` variant which takes excludes", "0.13.9")
def makeDependencies(dependencies: Seq[DependencyDescriptor], includeTypes: Set[String]): NodeSeq = def makeDependencies(dependencies: Seq[DependencyDescriptor], includeTypes: Set[String]): NodeSeq =
makeDependencies(dependencies, includeTypes, Nil)
def makeDependencies(dependencies: Seq[DependencyDescriptor], includeTypes: Set[String], excludes: Seq[ExcludeRule]): NodeSeq =
if (dependencies.isEmpty) if (dependencies.isEmpty)
NodeSeq.Empty NodeSeq.Empty
else else
<dependencies> <dependencies>
{ dependencies.map(makeDependency(_, includeTypes)) } { dependencies.map(makeDependency(_, includeTypes, excludes)) }
</dependencies> </dependencies>
@deprecated("Use `makeDependency` variant which takes excludes", "0.13.9")
def makeDependency(dependency: DependencyDescriptor, includeTypes: Set[String]): NodeSeq = def makeDependency(dependency: DependencyDescriptor, includeTypes: Set[String]): NodeSeq =
makeDependency(dependency, includeTypes, Nil)
def makeDependency(dependency: DependencyDescriptor, includeTypes: Set[String], excludes: Seq[ExcludeRule]): NodeSeq =
{ {
val artifacts = dependency.getAllDependencyArtifacts val artifacts = dependency.getAllDependencyArtifacts
val includeArtifacts = artifacts.filter(d => includeTypes(d.getType)) val includeArtifacts = artifacts.filter(d => includeTypes(d.getType))
if (artifacts.isEmpty) { if (artifacts.isEmpty) {
val configs = dependency.getModuleConfigurations val configs = dependency.getModuleConfigurations
if (configs.filterNot(Set("sources","docs")).nonEmpty) { if (configs.filterNot(Set("sources", "docs")).nonEmpty) {
val (scope, optional) = getScopeAndOptional(dependency.getModuleConfigurations) val (scope, optional) = getScopeAndOptional(dependency.getModuleConfigurations)
makeDependencyElem(dependency, scope, optional, None, None) makeDependencyElem(dependency, scope, optional, None, None, excludes)
} else NodeSeq.Empty } else NodeSeq.Empty
} else if (includeArtifacts.isEmpty) } else if (includeArtifacts.isEmpty)
NodeSeq.Empty NodeSeq.Empty
else else
NodeSeq.fromSeq(artifacts.flatMap(a => makeDependencyElem(dependency, a))) NodeSeq.fromSeq(artifacts.flatMap(a => makeDependencyElem(dependency, a, excludes)))
} }
@deprecated("Use `makeDependencyElem` variant which takes excludes", "0.13.9")
def makeDependencyElem(dependency: DependencyDescriptor, artifact: DependencyArtifactDescriptor): Option[Elem] = def makeDependencyElem(dependency: DependencyDescriptor, artifact: DependencyArtifactDescriptor): Option[Elem] =
makeDependencyElem(dependency, artifact, Nil)
def makeDependencyElem(dependency: DependencyDescriptor, artifact: DependencyArtifactDescriptor, excludes: Seq[ExcludeRule]): Option[Elem] =
{ {
val configs = artifact.getConfigurations.toList match { val configs = artifact.getConfigurations.toList match {
case Nil | "*" :: Nil => dependency.getModuleConfigurations case Nil | "*" :: Nil => dependency.getModuleConfigurations
case x => x.toArray case x => x.toArray
} }
if (configs.filterNot(Set("sources","docs")).nonEmpty) { if (configs.filterNot(Set("sources", "docs")).nonEmpty) {
val (scope, optional) = getScopeAndOptional(configs) val (scope, optional) = getScopeAndOptional(configs)
val classifier = artifactClassifier(artifact) val classifier = artifactClassifier(artifact)
val baseType = artifactType(artifact) val baseType = artifactType(artifact)
@ -258,10 +270,15 @@ class MakePom(val log: Logger) {
case (Some(c), Some(tpe)) if Artifact.classifierType(c) == tpe => None case (Some(c), Some(tpe)) if Artifact.classifierType(c) == tpe => None
case _ => baseType case _ => baseType
} }
Some(makeDependencyElem(dependency, scope, optional, classifier, tpe)) Some(makeDependencyElem(dependency, scope, optional, classifier, tpe, excludes))
} else None } else None
} }
@deprecated("Use `makeDependencyElem` variant which takes excludes", "0.13.9")
def makeDependencyElem(dependency: DependencyDescriptor, scope: Option[String], optional: Boolean, classifier: Option[String], tpe: Option[String]): Elem = def makeDependencyElem(dependency: DependencyDescriptor, scope: Option[String], optional: Boolean, classifier: Option[String], tpe: Option[String]): Elem =
makeDependencyElem(dependency, scope, optional, classifier, tpe, Nil)
def makeDependencyElem(dependency: DependencyDescriptor, scope: Option[String], optional: Boolean, classifier: Option[String], tpe: Option[String], excludes: Seq[ExcludeRule]): Elem =
{ {
val mrid = dependency.getDependencyRevisionId val mrid = dependency.getDependencyRevisionId
<dependency> <dependency>
@ -272,7 +289,7 @@ class MakePom(val log: Logger) {
{ optionalElem(optional) } { optionalElem(optional) }
{ classifierElem(classifier) } { classifierElem(classifier) }
{ typeElem(tpe) } { typeElem(tpe) }
{ exclusions(dependency) } { exclusions(dependency, excludes) }
</dependency> </dependency>
} }
@ -322,9 +339,12 @@ class MakePom(val log: Logger) {
(scope, opt.nonEmpty) (scope, opt.nonEmpty)
} }
def exclusions(dependency: DependencyDescriptor): NodeSeq = @deprecated("Use `exclusions` variant which takes excludes", "0.13.9")
def exclusions(dependency: DependencyDescriptor): NodeSeq = exclusions(dependency, Nil)
def exclusions(dependency: DependencyDescriptor, excludes: Seq[ExcludeRule]): NodeSeq =
{ {
val excl = dependency.getExcludeRules(dependency.getModuleConfigurations) val excl = dependency.getExcludeRules(dependency.getModuleConfigurations) ++ excludes
val (warns, excls) = IvyUtil.separate(excl.map(makeExclusion)) val (warns, excls) = IvyUtil.separate(excl.map(makeExclusion))
if (warns.nonEmpty) log.warn(warns.mkString(IO.Newline)) if (warns.nonEmpty) log.warn(warns.mkString(IO.Newline))
if (excls.nonEmpty) <exclusions>{ excls }</exclusions> if (excls.nonEmpty) <exclusions>{ excls }</exclusions>