implement secondary match

This commit is contained in:
Eugene Yokota 2020-08-22 15:13:47 -04:00
parent 5dfbcfb112
commit b42f3938a5
6 changed files with 74 additions and 10 deletions

View File

@ -23,16 +23,50 @@ object VirtualAxis {
abstract class StrongAxis extends VirtualAxis
def isMatch(lhs: Seq[VirtualAxis], rhs: Seq[VirtualAxis]): Boolean = {
def isCompatible(v: VirtualAxis, stack: Seq[VirtualAxis]): Boolean =
v match {
case v: WeakAxis =>
val clazz = v.getClass
stack.contains(v) || !stack.exists(_.getClass == clazz)
case v: StrongAxis =>
stack.contains(v)
def isMatch(lhs: Seq[VirtualAxis], rhs: Seq[VirtualAxis]): Boolean =
lhs.forall(isStronglyCompatible(_, rhs)) && rhs.forall(isStronglyCompatible(_, lhs))
private[sbt] def isStronglyCompatible(v: VirtualAxis, stack: Seq[VirtualAxis]): Boolean =
v match {
case v: WeakAxis =>
val clazz = v.getClass
stack.contains(v) || !stack.exists(_.getClass == clazz)
case v: StrongAxis =>
stack.contains(v)
}
def isSecondaryMatch(lhs: Seq[VirtualAxis], rhs: Seq[VirtualAxis]): Boolean =
lhs.forall(isSecondaryCompatible(_, rhs)) && rhs.forall(isSecondaryCompatible(_, lhs))
def isSecondaryCompatible(v: VirtualAxis, stack: Seq[VirtualAxis]): Boolean =
v match {
case v: ScalaVersionAxis =>
val thatSVOpt = (stack collect {
case x: ScalaVersionAxis => x
}).headOption
thatSVOpt match {
case Some(ScalaVersionAxis(sv, _)) =>
(v.scalaVersion == sv) ||
isScala2Scala3Sandwich(partialVersion(v.scalaVersion), partialVersion(sv))
case _ => true
}
case _ =>
isStronglyCompatible(v, stack)
}
private[sbt] def isScala2Scala3Sandwich(sbv1: Option[(Long, Long)], sbv2: Option[(Long, Long)]): Boolean = {
def str(x: Option[(Long, Long)]): String =
x match {
case Some((a, b)) => s"$a.$b"
case _ => "0.0"
}
lhs.forall(isCompatible(_, rhs)) && rhs.forall(isCompatible(_, lhs))
isScala2Scala3Sandwich(str(sbv1), str(sbv2))
}
private[sbt] def isScala2Scala3Sandwich(sbv1: String, sbv2: String): Boolean = {
def compare(a: String, b: String): Boolean =
a == "2.13" && (b.startsWith("0.") || b.startsWith("3.0"))
compare(sbv1, sbv2) || compare(sbv2, sbv1)
}
case class ScalaVersionAxis(scalaVersion: String, value: String) extends WeakAxis {

View File

@ -163,6 +163,9 @@ object ProjectMatrix {
def isMatch(that: ProjectRow): Boolean =
VirtualAxis.isMatch(this.axisValues, that.axisValues)
def isSecondaryMatch(that: ProjectRow): Boolean =
VirtualAxis.isSecondaryMatch(this.axisValues, that.axisValues)
override def toString: String = s"ProjectRow($autoScalaLibrary, $axisValues)"
}
@ -275,7 +278,8 @@ object ProjectMatrix {
// resolve to the closest match for the given row
private[sbt] def resolveMatch(thatRow: ProjectRow): ProjectReference =
rows.find(r => r.isMatch(thatRow)) match {
(rows.find(r => r.isMatch(thatRow)) orElse
rows.find(r => r.isSecondaryMatch(thatRow))) match {
case Some(r) => LocalProject(resolveProjectIds(r))
case _ => sys.error(s"no rows were found in $id matching $thatRow: $rows")
}

View File

@ -0,0 +1,17 @@
val dottyVersion = "0.23.0"
ThisBuild / resolvers += "scala-integration" at "https://scala-ci.typesafe.com/artifactory/scala-integration/"
// TODO use 2.13.4 when it's out
lazy val scala213 = "2.13.4-bin-aeee8f0"
lazy val fooApp = (projectMatrix in file("foo-app"))
.dependsOn(fooCore)
.settings(
name := "app",
)
.jvmPlatform(scalaVersions = Seq(dottyVersion))
lazy val fooCore = (projectMatrix in file("foo-core"))
.settings(
name := "core",
)
.jvmPlatform(scalaVersions = Seq("2.13.3", "2.12.12"))

View File

@ -0,0 +1 @@
sbt.version=1.3.13

View File

@ -0,0 +1,6 @@
sys.props.get("plugin.version") match {
case Some(x) => addSbtPlugin("com.eed3si9n" % "sbt-projectmatrix" % x)
case _ => sys.error("""|The system property 'plugin.version' is not defined.
|Specify this property using the scriptedLaunchOpts -D.""".stripMargin)
}
addSbtPlugin("ch.epfl.lamp" % "sbt-dotty" % "0.4.1")

View File

@ -0,0 +1,2 @@
> fooAppJVM0_23/compile