Merge pull request #1744 from eed3si9n/fix/1743

Fixes #1743. Fixes IndexOutOfBoundsException on Java warning with no position

compile/src/main/scala/sbt/compiler/javac/DiagnosticsReporter.scala

@@ -4,7 +4,8 @@ import java.io.File
 import javax.tools.{ Diagnostic, JavaFileObject, DiagnosticListener }
 
 import sbt.Logger
-import xsbti.{ Severity, Reporter }
+import xsbti.{ Severity, Reporter, Maybe }
+import javax.tools.Diagnostic.NOPOS
 
 /**
  * A diagnostics listener that feeds all messages into the given reporter.
@@ -55,19 +56,31 @@ final class DiagnosticsReporter(reporter: Reporter) extends DiagnosticListener[J
     val msg = fixedDiagnosticMessage(d)
     val pos: xsbti.Position =
       new xsbti.Position {
-        override val line =
-          Logger.o2m(if (d.getLineNumber == -1) None
-          else Option(new Integer(d.getLineNumber.toInt)))
-        override def lineContent = {
-          // TODO - Is this pulling contents of the line correctly?
-          // Would be ok to just return null if this version of the JDK doesn't support grabbing
-          // source lines?
-          Option(d.getSource).
-            flatMap(s => Option(s.getCharContent(true))).
-            map(_.subSequence(d.getStartPosition.intValue, d.getEndPosition.intValue).toString).
-            getOrElse("")
-        }
-        override val offset = Logger.o2m(Option(Integer.valueOf(d.getPosition.toInt)))
+        // https://docs.oracle.com/javase/7/docs/api/javax/tools/Diagnostic.html
+        // Negative values (except NOPOS) and 0 are not valid line or column numbers.
+        private[this] def checkNoPos(n: Long): Option[Long] =
+          n match {
+            case NOPOS       => None
+            case x if x <= 0 => sys.error(s"Invalid position: $x")
+            case x           => Option(x)
+          }
+
+        override val line: Maybe[Integer] = Logger.o2m(checkNoPos(d.getLineNumber) map { x => new Integer(x.toInt) })
+        def startPosition: Option[Long] = checkNoPos(d.getStartPosition)
+        def endPosition: Option[Long] = checkNoPos(d.getEndPosition)
+        override val offset: Maybe[Integer] = Logger.o2m(checkNoPos(d.getPosition) map { x => new Integer(x.toInt) })
+        // TODO - Is this pulling contents of the line correctly?
+        // Would be ok to just return null if this version of the JDK doesn't support grabbing
+        // source lines?
+        override def lineContent: String =
+          Option(d.getSource) match {
+            case Some(source: JavaFileObject) =>
+              (Option(source.getCharContent(true)), startPosition, endPosition) match {
+                case (Some(cc), Some(start), Some(end)) => cc.subSequence(start.toInt, end.toInt).toString
+                case _                                  => ""
+              }
+            case _ => ""
+          }
         private val sourceUri = fixSource(d.getSource)
         override val sourcePath = Logger.o2m(sourceUri)
         override val sourceFile = Logger.o2m(sourceUri.map(new File(_)))

notes/0.13.8.markdown

@@ -4,6 +4,7 @@
 [1180]: https://github.com/sbt/sbt/pull/1702
 [875]: https://github.com/sbt/sbt/issues/875
 [1542]: https://github.com/sbt/sbt/issues/1542
+[1702]: https://github.com/sbt/sbt/pull/1702
 
 ### Improvements
 
@@ -12,5 +13,5 @@
 
 ## Fixes
 
-- Javac warnings now always treated as warnings.  [#875][875] by [@jsuereth][jsuereth]
+- Javac warnings now always treated as warnings.  [#1702][1702]/[#875][875] by [@jsuereth][jsuereth]
 - compilerReporter now fed to javac during incremental compilation. [#1542][1542] by [@jsuereth][jsuereth]