luke
/
sbt
mirror of https://github.com/sbt/sbt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2356 from dwijnand/drop-sealed-from-Append-typeclasses 

Drop sealed from the typeclasses in Append
This commit is contained in:
eugene yokota 2016-01-08 12:19:33 -05:00
parent a9d80cf38c c5949268ef
commit 40e598f641
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
main/settings/src/main/scala/sbt/Append.scala
View File

@ -7,14 +7,14 @@ import sbt.internal.util.Attributed
object Append { object Append {
@implicitNotFound(msg = "No implicit for Append.Value[${A}, ${B}] found,\n so ${B} cannot be appended to ${A}") @implicitNotFound(msg = "No implicit for Append.Value[${A}, ${B}] found,\n so ${B} cannot be appended to ${A}")
sealed trait Value[A, B] { trait Value[A, B] {
def appendValue(a: A, b: B): A def appendValue(a: A, b: B): A
} }
@implicitNotFound(msg = "No implicit for Append.Values[${A}, ${B}] found,\n so ${B} cannot be appended to ${A}") @implicitNotFound(msg = "No implicit for Append.Values[${A}, ${B}] found,\n so ${B} cannot be appended to ${A}")
sealed trait Values[A, -B] { trait Values[A, -B] {
def appendValues(a: A, b: B): A def appendValues(a: A, b: B): A
} }
sealed trait Sequence[A, -B, T] extends Value[A, T] with Values[A, B] trait Sequence[A, -B, T] extends Value[A, T] with Values[A, B]
implicit def appendSeq[T, V <: T]: Sequence[Seq[T], Seq[V], V] = new Sequence[Seq[T], Seq[V], V] { implicit def appendSeq[T, V <: T]: Sequence[Seq[T], Seq[V], V] = new Sequence[Seq[T], Seq[V], V] {
def appendValues(a: Seq[T], b: Seq[V]): Seq[T] = a ++ b def appendValues(a: Seq[T], b: Seq[V]): Seq[T] = a ++ b

10
notes/0.13.10/drop-sealed-from-Append-typeclasses.markdown Normal file
View File

@ -0,0 +1,10 @@
[1171]: https://github.com/sbt/sbt/issues/1171
[2322]: https://github.com/sbt/sbt/pull/2322
### Fixes with compatibility implications
### Improvements
- Drops `sealed` from the typeclasses in Append. [#2322][] by [@dwijnand][]
### Bug fixes