luke
/
sbt
mirror of https://github.com/sbt/sbt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

change Scala binary version check to a warning

This commit is contained in:
Mark Harrah 2012-05-06 14:15:03 -04:00
parent 99a04466f1
commit 1c1d7b41a5
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ivy/Ivy.scala
View File

@ -132,7 +132,7 @@ final class IvySbt(val configuration: IvyConfiguration)
case pc: PomConfiguration => configurePom(pc) case pc: PomConfiguration => configurePom(pc)
case ifc: IvyFileConfiguration => configureIvyFile(ifc) case ifc: IvyFileConfiguration => configureIvyFile(ifc)
} }
moduleSettings.ivyScala.foreach(IvyScala.checkModule(baseModule, baseConfiguration)) moduleSettings.ivyScala.foreach(IvyScala.checkModule(baseModule, baseConfiguration, configuration.log))
IvySbt.addExtraNamespace(baseModule) IvySbt.addExtraNamespace(baseModule)
(baseModule, baseConfiguration) (baseModule, baseConfiguration)
} }

10
ivy/IvyScala.scala
View File

@ -33,10 +33,10 @@ final case class IvyScala(scalaFullVersion: String, scalaBinaryVersion: String,
private object IvyScala private object IvyScala
{ {
/** Performs checks/adds filters on Scala dependencies (if enabled in IvyScala). */ /** Performs checks/adds filters on Scala dependencies (if enabled in IvyScala). */
def checkModule(module: DefaultModuleDescriptor, conf: String)(check: IvyScala) def checkModule(module: DefaultModuleDescriptor, conf: String, log: Logger)(check: IvyScala)
{ {
if(check.checkExplicit) if(check.checkExplicit)
checkDependencies(module, check.scalaBinaryVersion, check.configurations) checkDependencies(module, check.scalaBinaryVersion, check.configurations, log)
if(check.filterImplicit) if(check.filterImplicit)
excludeScalaJars(module, check.configurations) excludeScalaJars(module, check.configurations)
if(check.overrideScalaVersion) if(check.overrideScalaVersion)
@ -56,7 +56,7 @@ private object IvyScala
/** Checks the immediate dependencies of module for dependencies on scala jars and verifies that the version on the /** Checks the immediate dependencies of module for dependencies on scala jars and verifies that the version on the
* dependencies matches scalaVersion. */ * dependencies matches scalaVersion. */
private def checkDependencies(module: ModuleDescriptor, scalaBinaryVersion: String, configurations: Iterable[Configuration]) private def checkDependencies(module: ModuleDescriptor, scalaBinaryVersion: String, configurations: Iterable[Configuration], log: Logger)
{ {
val configSet = if(configurations.isEmpty) (c: String) => true else configurationSet(configurations) val configSet = if(configurations.isEmpty) (c: String) => true else configurationSet(configurations)
for(dep <- module.getDependencies.toList) for(dep <- module.getDependencies.toList)
@ -64,7 +64,9 @@ private object IvyScala
val id = dep.getDependencyRevisionId val id = dep.getDependencyRevisionId
val depBinaryVersion = CrossVersion.binaryScalaVersion(id.getRevision) val depBinaryVersion = CrossVersion.binaryScalaVersion(id.getRevision)
if(id.getOrganisation == Organization && depBinaryVersion != scalaBinaryVersion && dep.getModuleConfigurations.exists(configSet)) if(id.getOrganisation == Organization && depBinaryVersion != scalaBinaryVersion && dep.getModuleConfigurations.exists(configSet))
error("Binary version for dependency " + id + " (" + depBinaryVersion + ") differs from Scala binary version in project (" + scalaBinaryVersion + ").") log.warn("Binary version " + " (" + depBinaryVersion + ") for dependency " + id +
"\n\tin " + module.getModuleRevisionId +
" differs from Scala binary version in project (" + scalaBinaryVersion + ").")
} }
} }
private def configurationSet(configurations: Iterable[Configuration]) = configurations.map(_.toString).toSet private def configurationSet(configurations: Iterable[Configuration]) = configurations.map(_.toString).toSet