Address reviews

.github/workflows/nightly.yml

@@ -32,7 +32,7 @@ jobs:
       uses: actions/checkout@v4
       with:
         repository: sbt/zinc
-        ref: 1.10.x
+        ref: develop
         path: zinc
     - name: Setup JDK
       uses: actions/setup-java@v4

build.sbt

@@ -47,7 +47,7 @@ ThisBuild / libraryDependencySchemes += "org.scala-lang.modules" %% "scala-xml"
 
 Global / semanticdbEnabled := !(Global / insideCI).value
 // Change main/src/main/scala/sbt/plugins/SemanticdbPlugin.scala too, if you change this.
-Global / semanticdbVersion := "4.7.8"
+Global / semanticdbVersion := "4.9.9"
 val excludeLint = SettingKey[Set[Def.KeyedInitialize[_]]]("excludeLintKeys")
 Global / excludeLint := (Global / excludeLint).?.value.getOrElse(Set.empty)
 Global / excludeLint += Utils.componentID

main/src/main/scala/sbt/internal/AnalysisUtil.scala

@@ -34,8 +34,6 @@ private[sbt] object AnalysisUtil {
       mappers = ReadWriteMappers.getEmptyMappers(),
       sort = true,
       ec = scala.concurrent.ExecutionContext.global,
-      // reproducisble = true will wipe out the timestamp, which we need for sbt 1.x
-      // reproducible = false,
       parallelism = parallelism,
     )
 }

main/src/main/scala/sbt/internal/SysProp.scala

@@ -155,8 +155,6 @@ object SysProp {
   def useLog4J: Boolean = getOrFalse("sbt.log.uselog4j")
   def turbo: Boolean = getOrFalse("sbt.turbo")
   def pipelining: Boolean = getOrFalse("sbt.pipelining")
-  // opt-in or out of Zinc's consistent Analysis format.
-  def analysis2024: Boolean = getOrFalse("sbt.analysis2024")
 
   def taskTimings: Boolean = getOrFalse("sbt.task.timings")
   def taskTimingsOnShutdown: Boolean = getOrFalse("sbt.task.timings.on.shutdown")