luke
/
sbt
mirror of https://github.com/sbt/sbt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Generate error when multiple AutoPlugins provide the same Nature.

This commit is contained in:
Mark Harrah 2014-02-08 10:23:31 -05:00
parent 708a3b107b
commit 0fc5f1525e
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
main/src/main/scala/sbt/AutoPlugin.scala
View File

@ -78,7 +78,7 @@ abstract class AutoPlugin
/** An error that occurs when auto-plugins aren't configured properly.
* It translates the error from the underlying logic system to be targeted at end users. */
final class AutoPluginException(val origin: LogicException, prefix: String) extends RuntimeException(prefix + Natures.translateMessage(origin))
final class AutoPluginException(val origin: Option[LogicException], prefix: String) extends RuntimeException(prefix + Natures.translateMessage(origin))
{
/** Prepends `p` to the error message derived from `origin`. */
def withPrefix(p: String) = new AutoPluginException(origin, p)
@ -109,7 +109,9 @@ object Natures
Types.const(Nil)
else
{
val byAtom = defined.map(x => (Atom(x.provides.label), x)).toMap
val byAtom = defined.map(x => (Atom(x.provides.label), x))
val byAtomMap = byAtom.toMap
if(byAtom.size != byAtomMap.size) duplicateProvidesError(byAtom)
val clauses = Clauses( defined.map(d => asClause(d)) )
requestedNatures =>
Logic.reduce(clauses, flatten(requestedNatures).toSet) match {
@ -117,7 +119,7 @@ object Natures
case Right(results) =>
// results includes the originally requested (positive) atoms,
// which won't have a corresponding AutoPlugin to map back to
results.ordered.flatMap(a => byAtom.get(a).toList)
results.ordered.flatMap(a => byAtomMap.get(a).toList)
}
}
@ -129,6 +131,15 @@ object Natures
private[this] def literalsString(lits: Seq[Literal]): String =
lits map { case Atom(l) => l; case Negated(Atom(l)) => l } mkString(", ")
private[this] def duplicateProvidesError(byAtom: Seq[(Atom, AutoPlugin)]) {
val dupsByAtom = defined.groupBy(_._1).mapValues(_._2)
val dupStrings = for( (atom, dups) <- dupsByAtom if dups.size > 1 ) yield
s"${atom.label} by ${dups.mkString(", ")}
val (ns, nl) = if(dupStrings > 1) ("s", "\n\t") else ("", " ")
val message = s"Nature$ns provided by multiple AutoPlugins:$nl${dupStrings.mkString(nl)}"
throw new AutoPluginException(None, message)
}
/** [[Natures]] instance that doesn't require any [[Nature]]s. */
def empty: Natures = Empty
private[sbt] final object Empty extends Natures {