mirror of https://github.com/openXC7/prjxray.git
4e14c2d330
configuration.cc explicitly specializes
Configuration<Spartan6>::createType2ConfigurationPacketData and
Configuration<...>::createConfigurationPackage (Spartan6, Series7,
UltraScale, UltraScalePlus), but none of those specializations were
declared in configuration.h. The standard requires an explicit
specialization to be declared in every translation unit that uses it
([temp.expl.spec]); without the declaration, a TU calling
createType2ConfigurationPacketData for Spartan6 instantiates the
primary template — which is defined in this header — and emits its own
COMDAT copy of the symbol.
That copy collides with the strong definition from configuration.cc
when linking xc7frames2bit/xc7patch with mingw-w64 ld ("multiple
definition of ...createType2ConfigurationPacketData..."), which is why
Windows builds needed -Wl,--allow-multiple-definition. ELF linkers
happen to resolve the collision silently in favour of the strong
symbol, so Linux builds never noticed.
Declare all five specializations in the header so every user
references the single definition in configuration.cc. Verified with a
mingw-w64 cross build: the tools now link without the workaround
linker flag. No behaviour change on ELF.
|
||
|---|---|---|
| .. | ||
| include/prjxray | ||
| test_data | ||
| xilinx | ||
| CMakeLists.txt | ||
| big_endian_span_test.cc | ||
| bit_ops_test.cc | ||
| database.cc | ||
| memory_mapped_file.cc | ||
| memory_mapped_file_test.cc | ||
| segbits_file_reader.cc | ||
| segbits_file_reader_test.cc | ||