luke/openFPGALoader
1
0
Fork 0
mirror of https://github.com/trabucayre/openFPGALoader.git synced 2026-08-31 18:26:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

colognechip integration: apply review remarks

Browse Source 
* add missing #include <string>
* add comment to part.hpp why highest nibble should be kept
* remove _reverseOrder variable from colognechipCfgParser.{hpp,cpp}
* rename cfgDone() to to a more meaningfull waitCfgDone()
This commit is contained in:
Patrick Urban
2021-12-12 11:55:10 +01:00
parent dd0d668d96
commit e252e713dd
5 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/colognechip.cpp
+5 -5
View File
@@ -84,7 +84,7 @@ void CologneChip::reset()
* Obtain CFG_DONE and ~CFG_FAILED signals. Configuration is successfull iff
* CFG_DONE=true and ~CFG_FAILED=false.
*/
bool CologneChip::cfgDone()
bool CologneChip::waitCfgDone()
{
uint16_t status = 0;
if (_spi) {
@@ -152,7 +152,7 @@ void CologneChip::program(unsigned int offset)
if (_file_extension == "bit") {
cfg = new RawParser(_filename, false);
} else if (_file_extension == "cfg") {
cfg = new CologneChipCfgParser(_filename, false);
cfg = new CologneChipCfgParser(_filename);
}
cfg->parse();
@@ -197,7 +197,7 @@ void CologneChip::programSPI_sram(uint8_t *data, int length)
do {
timeout--;
usleep(SLEEP_US);
} while (!cfgDone() && timeout > 0);
} while (!waitCfgDone() && timeout > 0);
if (timeout == 0) {
printError("FAIL");
} else {
@@ -240,7 +240,7 @@ void CologneChip::programSPI_flash(unsigned int offset, uint8_t *data, int lengt
do {
timeout--;
usleep(SLEEP_US);
} while (!cfgDone() && timeout > 0);
} while (!waitCfgDone() && timeout > 0);
if (timeout == 0) {
printError("FAIL");
} else {
@@ -288,7 +288,7 @@ void CologneChip::programJTAG_sram(uint8_t *data, int length)
do {
timeout--;
usleep(SLEEP_US);
} while (!cfgDone() && timeout > 0);
} while (!waitCfgDone() && timeout > 0);
if (timeout == 0) {
printError("FAIL");
} else {